Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🪟🐛 Connector form: Render input as number for type number #20637

Merged
merged 3 commits into from
Jan 2, 2023

Conversation

flash1293
Copy link
Contributor

What

When type: number is used in the connector form, the value is cast correctly to a number, but the input it still rendered as type text which makes it possible for the user to type string values as well.

This PR fixes this problem by switching the input type to number for this property type.

@octavia-squidington-iv octavia-squidington-iv added the area/platform issues related to the platform label Dec 19, 2022
@flash1293 flash1293 marked this pull request as ready for review December 19, 2022 16:44
@flash1293 flash1293 requested a review from a team as a code owner December 19, 2022 16:44
Copy link
Contributor

@lmossman lmossman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested locally and works as expected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend Related to the Airbyte webapp area/platform issues related to the platform team/extensibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants