Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source notion: fix schema #20639

Merged
merged 11 commits into from
Jan 11, 2023
Merged
Next Next commit
#1047 oncall - Source Notion: fix Pages stream schema
  • Loading branch information
davydov-d committed Dec 19, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit c349b13b6e2e8bce544f6ff07903c31ea7465482
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-notion/Dockerfile
Original file line number Diff line number Diff line change
@@ -34,5 +34,5 @@ COPY source_notion ./source_notion
ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]

LABEL io.airbyte.version=0.1.10
LABEL io.airbyte.version=1.0.0
LABEL io.airbyte.name=airbyte/source-notion
Original file line number Diff line number Diff line change
@@ -1,28 +1,36 @@
# See [Source Acceptance Tests](https://docs.airbyte.com/connector-development/testing-connectors/source-acceptance-tests-reference)
# for more information about how to configure these tests
connector_image: airbyte/source-notion:dev
tests:
test_strictness_level: high
davydov-d marked this conversation as resolved.
Show resolved Hide resolved
acceptance_tests:
spec:
- spec_path: "source_notion/spec.json"
tests:
- spec_path: "source_notion/spec.json"
connection:
- config_path: "secrets/config.json"
status: "succeed"
- config_path: "secrets/config_oauth.json"
status: "succeed"
- config_path: "integration_tests/invalid_config.json"
status: "failed"
tests:
- config_path: "secrets/config.json"
status: "succeed"
- config_path: "secrets/config_oauth.json"
status: "succeed"
- config_path: "integration_tests/invalid_config.json"
status: "failed"
discovery:
- config_path: "secrets/config.json"
tests:
- config_path: "secrets/config.json"
basic_read:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/configured_catalog.json"
empty_streams: []
tests:
- config_path: "secrets/config.json"
expect_records:
path: "integration_tests/expected_records.txt"
incremental:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/configured_catalog.json"
future_state_path: "integration_tests/abnormal_state.json"
tests:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/incremental_catalog.json"
future_state:
future_state_path: "integration_tests/abnormal_state.json"
full_refresh:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/configured_catalog.json"
ignored_fields:
"pages": ["icon"]
tests:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/configured_catalog.json"
ignored_fields:
"pages": ["icon"]
davydov-d marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
@@ -4,35 +4,52 @@
"stream": {
"name": "users",
"json_schema": {},
"supported_sync_modes": ["full_refresh"]
"supported_sync_modes": ["full_refresh"],
"default_primary_key": [["id"]]
},
"sync_mode": "full_refresh",
"destination_sync_mode": "overwrite"
"destination_sync_mode": "overwrite",
"primary_key": [["id"]]
},
{
"stream": {
"name": "databases",
"json_schema": {},
"supported_sync_modes": ["incremental"]
"supported_sync_modes": ["full_refresh", "incremental"],
"source_defined_cursor": true,
"default_primary_key": [["id"]],
"default_cursor_field": ["last_edited_time"]
},
"primary_key": [["id"]],
"cursor_field": ["last_edited_time"],
"sync_mode": "incremental",
"destination_sync_mode": "append"
},
{
"stream": {
"name": "pages",
"json_schema": {},
"supported_sync_modes": ["incremental"]
"supported_sync_modes": ["full_refresh", "incremental"],
"source_defined_cursor": true,
"default_primary_key": [["id"]],
"default_cursor_field": ["last_edited_time"]
},
"primary_key": [["id"]],
"cursor_field": ["last_edited_time"],
"sync_mode": "incremental",
"destination_sync_mode": "append"
},
{
"stream": {
"name": "blocks",
"json_schema": {},
"supported_sync_modes": ["incremental"]
"supported_sync_modes": ["full_refresh", "incremental"],
"source_defined_cursor": true,
"default_primary_key": [["id"]],
"default_cursor_field": ["last_edited_time"]
},
"primary_key": [["id"]],
"cursor_field": ["last_edited_time"],
"sync_mode": "incremental",
"destination_sync_mode": "append"
}
Loading