🪟 🧪 E2E Tests for auto-detect schema changes #20682

edmundito · 2022-12-19T21:23:46Z

What

Closes #17936

Adds E2E tests for auto-detect schema changes:

Verify the status on the connection list page
Verify that the user can save through the breaking and non-breaking flow
Verify that the user can update the non-breaking preference

To make this possible, there were a few additions to the cypress framework:

Adds the ability to create sources, destinations, and connections without using the UI
Update the db query helpers to be able to generate SQL commands more easily

krishnaglick · 2023-01-03T17:08:48Z

airbyte-webapp-e2e-tests/cypress/commands/utils/promise.ts

+ * Converts Cypress chain to regular Promise.
+ */
+export const toPromise = <T>(chain: Cypress.Chainable<T>): Promise<T> => {
+  return new Cypress.Promise((resolve, reject) => {


Suggested change

return new Cypress.Promise((resolve, reject) => {

return new Cypress.Promise<T>((resolve, reject) => {

krishnaglick · 2023-01-03T17:18:14Z

airbyte-webapp-e2e-tests/cypress/pages/replicationPage.ts

+
+export const clickSchemaChangesReviewButton = () => {
+  cy.get(schemaChangesReviewButton).click();
+  // cy.get(schemaChangesReviewButton).should("be.disabled");


Why commented?
We need to enable the new table?

This was related to not disabling the button in the loading state, which is fixed in #20737

dizel852 · 2023-01-19T11:45:26Z

airbyte-webapp-e2e-tests/cypress/commands/db/queries.ts

+export const createTable = (tableName: string, columns: string[]): string =>
+  `CREATE TABLE ${tableName}(${columns.join(", ")});`;
+
+export const dropTable = (tableName: string) => `DROP TABLE IF EXISTS ${tableName}`;
+
+export const alterTable = (tableName: string, params: { add?: string[]; drop?: string[] }): string => {
+  const adds = params.add ? params.add.map((add) => `ADD COLUMN ${add}`) : [];
+  const drops = params.drop ? params.drop.map((columnName) => `DROP COLUMN ${columnName}`) : [];
+  const alterations = [...adds, ...drops];
+
+  return `ALTER TABLE ${tableName} ${alterations.join(", ")};`;
+};
+
+export const insertIntoTable = (tableName: string, valuesByColumn: Record<string, unknown>): string => {
+  const keys = Object.keys(valuesByColumn);
+  const values = keys
+    .map((key) => valuesByColumn[key])
+    .map((value) => (typeof value === "string" ? `'${value}'` : value));
+
+  return `INSERT INTO ${tableName}(${keys.join(", ")}) VALUES(${values.join(", ")});`;
+};
+


dizel852

🔥 Happy to see so many good improvements - create a connection via API, instead of running the full flow of creation a new connection 👍

Also tried to run new tests locally, but wasn't successful. Fails on statusCell:

… cypress

…on test

* Update db queries with generator functions * Update users table to include better columns and cursor * Add name to ResetWarningModalSwitch * Add test ID to review button in SchemaChangesDetected modal

…-detect e2e test

…n the schema change type

…for non-breaking changes

… records to users table

dizel852 · 2023-02-01T13:40:28Z

Tested locally, 1 test fails:

In the new table we use <SyncModeSelect />dropdown instead of the old one - <SyncSettingsDropdown />

edmundito · 2023-02-01T14:37:34Z

@dizel852 this is currently not compatible with the new table.

dizel852

Retested locally with old stream table - works like a charm 👍
Can't wait to start using the new test API 🔥

* master: (86 commits) Discover worker starts to use API to write schema result (#21875) 🪟 🎉 Connector Builder Landing Page (#22122) Fix pnpm cache path (#22418) Add additional shorter setup guides (#22318) Source Amazon Ads: fix reports stream records primary keys (#21677) Connector acceptance test: Fix discovered catalog caching for different configs (#22301) 🪟🐛 Make modal scrollable (#21973) only compute diff if the schema discovery actually succeeded (#22377) Source Klaviyo: fix schema (#22071) 🪟 🔧 Switch to `pnpm` for package managing (#22053) Source Sentry: turn on default availability strategy (#22303) Source freshdesk: deduplicate table names (#22164) Update connector-acceptance-tests-reference.md (#22370) Update the default security groups for the EC2 runner (#22347) Trace refresh schema operations (#22326) Remove manual docker upgrades from workflows (#22344) Update CODEOWNERS for connector acceptance tests to connector ops (#22341) 🐛 source: airtable - handle singleSelect types (#22311) Source tiktok: chunk advertiser IDs (#22309) 🪟 🧪 E2E Tests for auto-detect schema changes (#20682) ...

* master: (24 commits) Discover worker starts to use API to write schema result (#21875) 🪟 🎉 Connector Builder Landing Page (#22122) Fix pnpm cache path (#22418) Add additional shorter setup guides (#22318) Source Amazon Ads: fix reports stream records primary keys (#21677) Connector acceptance test: Fix discovered catalog caching for different configs (#22301) 🪟🐛 Make modal scrollable (#21973) only compute diff if the schema discovery actually succeeded (#22377) Source Klaviyo: fix schema (#22071) 🪟 🔧 Switch to `pnpm` for package managing (#22053) Source Sentry: turn on default availability strategy (#22303) Source freshdesk: deduplicate table names (#22164) Update connector-acceptance-tests-reference.md (#22370) Update the default security groups for the EC2 runner (#22347) Trace refresh schema operations (#22326) Remove manual docker upgrades from workflows (#22344) Update CODEOWNERS for connector acceptance tests to connector ops (#22341) 🐛 source: airtable - handle singleSelect types (#22311) Source tiktok: chunk advertiser IDs (#22309) 🪟 🧪 E2E Tests for auto-detect schema changes (#20682) ...

octavia-squidington-iv added area/platform issues related to the platform area/frontend Related to the Airbyte webapp labels Dec 19, 2022

edmundito marked this pull request as ready for review December 21, 2022 21:13

edmundito requested a review from a team as a code owner December 21, 2022 21:13

edmundito requested review from SofiiaZaitseva, dizel852 and krishnaglick and removed request for a team December 21, 2022 21:13

edmundito changed the title ~~[DRAFT] 🪟 🧪 E2E Tests for auto-detect schema changes~~ 🪟 🧪 E2E Tests for auto-detect schema changes Dec 22, 2022

krishnaglick reviewed Jan 3, 2023

View reviewed changes

edmundito removed the request for review from SofiiaZaitseva January 12, 2023 15:01

edmundito force-pushed the edmundito/auto-detect-schema-tests branch from 4924ed9 to 11a25db Compare January 18, 2023 21:43

octavia-squidington-iv removed the area/platform issues related to the platform label Jan 18, 2023

dizel852 reviewed Jan 19, 2023

View reviewed changes

edmundito force-pushed the edmundito/auto-detect-schema-tests branch from 11a25db to b80b47c Compare January 27, 2023 21:33

edmundito added 14 commits January 30, 2023 14:47

Add support to get workspaceId, create/delete source/destination from…

5ff8d49

… cypress

Test delete source

e751d9d

commands/request -> commands/api

7f771e9

Add util to convert chains to promises, cleanup api, use async/await …

b14f7eb

…on test

Add the ability to create and delete a connection

4758486

Add E2E test for non-breaking schema changes

679a608

* Update db queries with generator functions * Update users table to include better columns and cursor * Add name to ResetWarningModalSwitch * Add test ID to review button in SchemaChangesDetected modal

Add test for breaking change auto-detect flow

ca7369a

Fix linting issues

ed7a9c8

Clean up afterEach for autoDetectSchema

32f40a0

schemaChangesButton should be disabled after clicking

ed9e38f

Append random strings to source, dest, and connection created by auto…

1f9fefa

…-detect e2e test

Add E2E tests to verify status icon in list pages

aae4d3d

Ensure that the manual sync button is enabled or disabled depending o…

64f153c

…n the schema change type

Add test to verify non-breaking prefrence update

c9336bb

edmundito added 7 commits January 30, 2023 14:47

Fix testid prop case in StatusCell

ca31816

Fix small issues in auto-detect schema tests

0fc7d57

Remove it.only from autoDetectSchema.spec

00309ef

Remove promisification of api requests in e2e

6b99bab

Fix typing in apiRequest

96a712d

Cleanup requestWorkspaceId

fd30bdd

Update auto-detect e2e test to check where backdrop should not exist …

e06f4f5

…for non-breaking changes

edmundito force-pushed the edmundito/auto-detect-schema-tests branch from 45467f1 to e06f4f5 Compare January 30, 2023 19:57

edmundito requested a review from dizel852 January 30, 2023 19:58

edmundito added 2 commits January 30, 2023 15:06

Remove promise util for cypress

096f5f3

Fix column name in connection e2e spec

874f0e9

edmundito requested a review from ambirdsall January 30, 2023 20:54

Fix fields in connection spec to match the new users table. Add email…

14a29c5

… records to users table

dizel852 approved these changes Feb 2, 2023

View reviewed changes

edmundito merged commit c2890bf into master Feb 2, 2023

edmundito deleted the edmundito/auto-detect-schema-tests branch February 2, 2023 15:09

octavia-squidington-iii mentioned this pull request Feb 2, 2023

Bump Airbyte version from 0.40.32 to 0.40.33 #22335

Closed

github-actions bot mentioned this pull request Feb 7, 2023

Bump helm chart version reference to 0.43.28 #22489

Closed

This was referenced Feb 8, 2023

Bump Airbyte version from 0.40.32 to 0.40.33 #22578

Closed

Bump Airbyte version from 0.40.32 to 0.40.33 #22689

Closed

Bump Airbyte version from 0.40.32 to 0.40.33 #22839

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🪟 🧪 E2E Tests for auto-detect schema changes #20682

🪟 🧪 E2E Tests for auto-detect schema changes #20682

edmundito commented Dec 19, 2022 •

edited

Loading

krishnaglick Jan 3, 2023

krishnaglick Jan 3, 2023

edmundito Jan 27, 2023

dizel852 Jan 19, 2023

dizel852 left a comment

dizel852 commented Feb 1, 2023

edmundito commented Feb 1, 2023

dizel852 left a comment

	return new Cypress.Promise((resolve, reject) => {
	return new Cypress.Promise<T>((resolve, reject) => {

🪟 🧪 E2E Tests for auto-detect schema changes #20682

🪟 🧪 E2E Tests for auto-detect schema changes #20682

Conversation

edmundito commented Dec 19, 2022 • edited Loading

What

krishnaglick Jan 3, 2023

Choose a reason for hiding this comment

krishnaglick Jan 3, 2023

Choose a reason for hiding this comment

edmundito Jan 27, 2023

Choose a reason for hiding this comment

dizel852 Jan 19, 2023

Choose a reason for hiding this comment

dizel852 left a comment

Choose a reason for hiding this comment

dizel852 commented Feb 1, 2023

edmundito commented Feb 1, 2023

dizel852 left a comment

Choose a reason for hiding this comment

edmundito commented Dec 19, 2022 •

edited

Loading