Remove configRepository dependency from getStatus #20685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octavia-squidington-iv
added
area/platform
alovew
requested review from
benmoriceau,
jdpgrailsdev,
gosusnp and
colesnodgrass
| } catch (final JsonValidationException | ConfigNotFoundException | IOException e) { | ||
| final io.airbyte.api.client.model.generated.ConnectionIdRequestBody requestBody = | ||
| new io.airbyte.api.client.model.generated.ConnectionIdRequestBody().connectionId(connectionId); | ||
| final ConnectionRead connectionRead = connectionApi.getConnection(requestBody); |
There was a problem hiding this comment.
Consider extracting to a shared method as this code is now duplicated with the method above.
gosusnp
approved these changes
Dec 19, 2022
jdpgrailsdev
approved these changes
Dec 19, 2022
Nit about extracting common code -- could be done in a follow-on PR.
alovew
force-pushed
the
anne/update-get-status
branch
from
69a02cf to
279ece8
Compare
alovew
force-pushed
the
anne/update-get-status
branch
from
279ece8 to
abfd9d0
Compare
alovew
force-pushed
the
anne/auto-detect-schema
branch
from
c48e096 to
ab36efb
Compare
alovew
force-pushed
the
anne/update-get-status
branch
from
abfd9d0 to
c363b91
Compare
alovew
force-pushed
the
anne/auto-detect-schema
branch
from
ab36efb to
eee6193
Compare
alovew
force-pushed
the
anne/update-get-status
branch
from
04483ff to
33ce445
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove configRepository dependency from getStatus in the configFetchActivity