-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix a bug where the OAuthAuthenticator was misnamed #20700
fix a bug where the OAuthAuthenticator was misnamed #20700
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
/publish-cdk dry-run=false
|
/approve-and-merge reason=”small fix an issue w/ schema validation identified and blocking a community developer” |
What
#20422 (comment)
Fixes a small bug where the correct component name in our existing code was
OAuthAuthenticator
, but in the handwritten schema I accidentally named itDeclarativeOauthAuthenticator
which impacted someone developing an integration using that component.How
Correctly renames the component in the schema used to validate manifests:
Example of correct manifest which was tested against: