Fixing the connectors build w/ latest cdk models #20743
Conversation
…est schema updates
| @@ -1,918 +0,0 @@ | |||
| "$schema": http://json-schema.org/draft-07/schema# | |||
There was a problem hiding this comment.
we had renamed the schema to declarative_component_schema.yaml but this file was not removed. Just getting rid of it since it's unnecessary.
|
It should be part of CI since its integrated into the base connectors build and why it's failing now. Its possible that it wasn't caught the first time because the previous review was the first one to introduce the CI check. Now that its fully merged, now it will start catching them in all PRs But as it stands now, the models weren't regenerated against the latest schema most likely. If it were, then the |
|
/approve-and-merge reason="fixing a red build for connectors base” |
|
Myomoto says it looks good |
|
weird, octavia is just leaving my PR hanging. I'll try not to take offense |
|
/approve-and-merge reason="approved but never merged?” |
|
A crack team of mammals has made a decision. |
|
There was a message saying the branch was no up-to-date with master. Not sure if it could help but I did merge master in this branch and will try to |
|
/approve-and-merge reason="fixing a red build for connectors base” |
|
This looks fine! |
|
/approve-and-merge reason="Because Maxime asked" |
|
Approve this |
What
A prior merge didn't have the latest component schema up to date so we need to update the autogenerated code.
How
Ran
SUB_BUILD=CONNECTORS_BASE ./gradlew formatto regenerate models according to the latest schema and got rid of an unneeded file.