Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use explicit configuration for Micronaut endpoints #20759

Merged
merged 15 commits into from
Jan 6, 2023
Merged

Use explicit configuration for Micronaut endpoints #20759

merged 15 commits into from
Jan 6, 2023

Conversation

jdpgrailsdev
Copy link
Contributor

What

  • Use explicit configuration for built-in Micronaut endpoints

How

  • Remove intercept-url-map
  • Explicitly list built-in endpoints
  • Add anonymous security annotation to health/heartbeat endpoints

Recommended reading order

  1. application.yml

Tests

  • Ran locally and verified that the correct endpoints are reachable

@octavia-squidington-iv octavia-squidington-iv added area/platform issues related to the platform area/worker Related to worker labels Dec 21, 2022
@jdpgrailsdev jdpgrailsdev temporarily deployed to more-secrets January 3, 2023 14:11 — with GitHub Actions Inactive
@jdpgrailsdev jdpgrailsdev temporarily deployed to more-secrets January 3, 2023 14:11 — with GitHub Actions Inactive
@jdpgrailsdev jdpgrailsdev temporarily deployed to more-secrets January 3, 2023 14:27 — with GitHub Actions Inactive
@jdpgrailsdev jdpgrailsdev temporarily deployed to more-secrets January 3, 2023 14:27 — with GitHub Actions Inactive
@jdpgrailsdev jdpgrailsdev temporarily deployed to more-secrets January 3, 2023 15:29 — with GitHub Actions Inactive
@jdpgrailsdev jdpgrailsdev temporarily deployed to more-secrets January 3, 2023 15:29 — with GitHub Actions Inactive
@jdpgrailsdev jdpgrailsdev temporarily deployed to more-secrets January 3, 2023 16:34 — with GitHub Actions Inactive
@jdpgrailsdev jdpgrailsdev temporarily deployed to more-secrets January 3, 2023 16:35 — with GitHub Actions Inactive
@jdpgrailsdev jdpgrailsdev temporarily deployed to more-secrets January 3, 2023 17:20 — with GitHub Actions Inactive
@jdpgrailsdev jdpgrailsdev temporarily deployed to more-secrets January 3, 2023 17:20 — with GitHub Actions Inactive
@jdpgrailsdev jdpgrailsdev temporarily deployed to more-secrets January 3, 2023 17:24 — with GitHub Actions Inactive
@jdpgrailsdev jdpgrailsdev temporarily deployed to more-secrets January 3, 2023 17:24 — with GitHub Actions Inactive
@jdpgrailsdev jdpgrailsdev temporarily deployed to more-secrets January 3, 2023 17:37 — with GitHub Actions Inactive
@jdpgrailsdev jdpgrailsdev temporarily deployed to more-secrets January 3, 2023 17:37 — with GitHub Actions Inactive
@jdpgrailsdev jdpgrailsdev temporarily deployed to more-secrets January 3, 2023 18:14 — with GitHub Actions Inactive
@jdpgrailsdev jdpgrailsdev temporarily deployed to more-secrets January 3, 2023 18:14 — with GitHub Actions Inactive
@jdpgrailsdev jdpgrailsdev temporarily deployed to more-secrets January 3, 2023 18:57 — with GitHub Actions Inactive
@jdpgrailsdev jdpgrailsdev temporarily deployed to more-secrets January 3, 2023 18:58 — with GitHub Actions Inactive
@jdpgrailsdev jdpgrailsdev temporarily deployed to more-secrets January 3, 2023 19:34 — with GitHub Actions Inactive
@jdpgrailsdev jdpgrailsdev temporarily deployed to more-secrets January 3, 2023 19:34 — with GitHub Actions Inactive
@jdpgrailsdev jdpgrailsdev temporarily deployed to more-secrets January 3, 2023 20:08 — with GitHub Actions Inactive
@jdpgrailsdev jdpgrailsdev temporarily deployed to more-secrets January 3, 2023 20:08 — with GitHub Actions Inactive
@jdpgrailsdev jdpgrailsdev temporarily deployed to more-secrets January 3, 2023 22:05 — with GitHub Actions Inactive
@jdpgrailsdev jdpgrailsdev temporarily deployed to more-secrets January 3, 2023 22:05 — with GitHub Actions Inactive
@jdpgrailsdev jdpgrailsdev temporarily deployed to more-secrets January 4, 2023 13:58 — with GitHub Actions Inactive
@jdpgrailsdev jdpgrailsdev temporarily deployed to more-secrets January 4, 2023 13:58 — with GitHub Actions Inactive
@jdpgrailsdev jdpgrailsdev temporarily deployed to more-secrets January 6, 2023 17:21 — with GitHub Actions Inactive
@jdpgrailsdev jdpgrailsdev temporarily deployed to more-secrets January 6, 2023 17:21 — with GitHub Actions Inactive
@jdpgrailsdev jdpgrailsdev merged commit 31c28f5 into master Jan 6, 2023
@jdpgrailsdev jdpgrailsdev deleted the jonathan/micronaut-endpoint-security branch January 6, 2023 19:16
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Jan 6, 2023
Closed
@github-actions github-actions bot mentioned this pull request Jan 6, 2023
Closed
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Jan 6, 2023
Merged
jbfbell pushed a commit that referenced this pull request Jan 13, 2023
@jdpgrailsdev @jbfbell
Use explicit configuration for Micronaut endpoints (#20759)
18ea9ec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colesnodgrass colesnodgrass colesnodgrass approved these changes

@gosusnp gosusnp gosusnp approved these changes

@benmoriceau benmoriceau benmoriceau approved these changes

@alovew alovew Awaiting requested review from alovew

Assignees
No one assigned
Labels
area/platform issues related to the platform area/worker Related to worker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jdpgrailsdev @colesnodgrass @gosusnp @benmoriceau @octavia-squidington-iv