🪟🐛 Connector form: Remove empty strings from form values for optional properties #20808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flash1293
added
team/extensibility
area/frontend
josephkmh
reviewed
Jan 2, 2023
airbyte-webapp/src/views/Connector/ConnectorForm/components/Property/Control.tsx
Outdated
Show resolved
Hide resolved
|
@josephkmh glad you made the comment with the required field - the failing tests are an actual failure because if a field is set to undefined, formik will automatically fill in the default value again if there is one (this broke entering the port number in the e2e test). I fixed this case by not setting a field to undefined if there is a default value as formik will fill it in when casting so it won't send an empty string in this case either. Added it to the list of things that are annoying about formik... |
|
Good catch! That is a strange behavior, TIL. Never underestimate formik 😭 |
This was referenced Jan 6, 2023
This was referenced Jan 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes #8060
How
If a user is entering a value in an optional field and removes it subsequently, an empty string will reside in that property. This PR detects this situation and overrides the value with undefined in the same react commit.
This is done for regular inputs, textareas, secret inputs and textareas as well as date(-time) inputs. It does not happen for array-inputs and enums.