Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add feature to specify own selector and regular labels in deployment #20883

Merged
merged 3 commits into from
Dec 27, 2022
Merged

Add feature to specify own selector and regular labels in deployment #20883

merged 3 commits into from
Dec 27, 2022

Conversation

xpuska513
Copy link
Contributor

What

  • Add 2 new values extraLabels and extraSelectorLabels so users can specify their own labels for better resource management or monitoring

@xpuska513 xpuska513 requested a review from a team December 27, 2022 10:19
@octavia-squidington-iv octavia-squidington-iv added area/platform issues related to the platform kubernetes labels Dec 27, 2022
@xpuska513 xpuska513 temporarily deployed to more-secrets December 27, 2022 10:20 — with GitHub Actions Inactive
@xpuska513 xpuska513 temporarily deployed to more-secrets December 27, 2022 10:21 — with GitHub Actions Inactive
@xpuska513 xpuska513 temporarily deployed to more-secrets December 27, 2022 11:43 — with GitHub Actions Inactive
@xpuska513 xpuska513 temporarily deployed to more-secrets December 27, 2022 11:43 — with GitHub Actions Inactive
supertopher
supertopher approved these changes Dec 27, 2022
View reviewed changes
Copy link
Contributor

@supertopher supertopher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sanity check approval.

I think this is a good change for us and OSS. users

@xpuska513 xpuska513 merged commit c3c5a41 into master Dec 27, 2022
@xpuska513 xpuska513 deleted the kskobylko/add-custom-labels-to-helm-charts branch December 27, 2022 17:28
@github-actions github-actions bot mentioned this pull request Dec 27, 2022
Merged
This was referenced Jan 6, 2023
Closed
Closed
This was referenced Jan 6, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@supertopher supertopher supertopher approved these changes

Assignees
No one assigned
Labels
area/platform issues related to the platform kubernetes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xpuska513 @supertopher @octavia-squidington-iv