Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amazon Seller Partner: Validate connections without orders data #20896

Merged
merged 5 commits into from
Jan 9, 2023
Merged

Amazon Seller Partner: Validate connections without orders data #20896

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4bab078
amazon seller partner validate connection without orders data
animer3009 Dec 28, 2022
b1b3ae5
amazon seller partner bump version in docs
animer3009 Dec 28, 2022
e6b086a
amazon seller partner fix redundant if statement
animer3009 Jan 9, 2023
061601d
Merge branch 'master' into amazon_seller_partner_validate_connection
sajarin Jan 9, 2023
dba7638
auto-bump connector version
octavia-squidington-iii Jan 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-amazon-seller-partner/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,5 @@ RUN pip install .
ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]

LABEL io.airbyte.version=0.2.29
LABEL io.airbyte.version=0.2.30
LABEL io.airbyte.name=airbyte/source-amazon-seller-partner
5 changes: 2 additions & 3 deletions ...tegrations/connectors/source-amazon-seller-partner/source_amazon_seller_partner/source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,10 +139,9 @@ def check_connection(self, logger: AirbyteLogger, config: Mapping[str, Any]) ->

return True, None
except Exception as e:
# Validate Orders stream without data
if isinstance(e, StopIteration):
logger.error(
"Could not check connection without data for Orders stream. Please change value for replication start date field."
)
return True, None

# Additional check, since Vendor-ony accounts within Amazon Seller API will not pass the test without this exception
if "403 Client Error" in str(e):
Expand Down
1 change: 1 addition & 0 deletions docs/integrations/sources/amazon-seller-partner.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,7 @@ Make sure to configure the [required parameters](https://developer-docs.amazon.c

| Version | Date | Pull Request | Subject |
|:---------|:-----------|:-----------------------------------------------------------|:-----------------------------------------------------------------------|
| `0.2.30` | 2022-12-28 | [\#20896](https://github.com/airbytehq/airbyte/pull/20896) | Validate connections without orders data |
| `0.2.29` | 2022-11-18 | [\#19581](https://github.com/airbytehq/airbyte/pull/19581) | Use user provided end date for GET_SALES_AND_TRAFFIC_REPORT | |
| `0.2.28` | 2022-10-20 | [\#18283](https://github.com/airbytehq/airbyte/pull/18283) | Added multiple (22) report types |
| `0.2.26` | 2022-09-24 | [\#16629](https://github.com/airbytehq/airbyte/pull/16629) | Report API version to 2021-06-30, added multiple (5) report types |
Expand Down