Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New destination: databend (community PR #19815) #20909

Merged
merged 36 commits into from
Jan 9, 2023

Conversation

grishick
Copy link
Contributor

@grishick grishick commented Dec 28, 2022

Fixes #21140

Taking this community PR last mile to rebase and add integration tests.

@grishick grishick requested review from a team as code owners December 28, 2022 22:03
@grishick grishick requested a review from a team December 28, 2022 22:03
@grishick grishick requested a review from a team as a code owner December 28, 2022 22:03
@octavia-squidington-iv octavia-squidington-iv added area/connectors Connector related issues area/documentation Improvements or additions to documentation area/platform issues related to the platform normalization area/frontend Related to the Airbyte webapp connectors/destination/databend labels Dec 28, 2022
@grishick grishick mentioned this pull request Dec 28, 2022
37 tasks
@grishick grishick temporarily deployed to more-secrets December 28, 2022 22:05 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Dec 28, 2022

Affected Connector Report

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to do the following as needed:

  • Run integration tests
  • Bump connector or module version
  • Add changelog
  • Publish the new version

✅ Sources (0)

Connector Version Changelog Publish
  • See "Actionable Items" below for how to resolve warnings and errors.

❌ Destinations (16)

Connector Version Changelog Publish
destination-bigquery 1.2.9
destination-bigquery-denormalized 1.2.10
destination-clickhouse 0.2.1
destination-clickhouse-strict-encrypt 0.2.1 🔵
(ignored)
🔵
(ignored)
destination-jdbc 0.3.14 🔵
(ignored)
🔵
(ignored)
destination-mssql 0.1.22
destination-mssql-strict-encrypt 0.1.22 🔵
(ignored)
🔵
(ignored)
destination-mysql 0.1.20
destination-mysql-strict-encrypt 0.1.21
(mismatch: 0.1.20)
🔵
(ignored)
🔵
(ignored)
destination-oracle 0.1.19
destination-oracle-strict-encrypt 0.1.19 🔵
(ignored)
🔵
(ignored)
destination-postgres 0.3.26
destination-postgres-strict-encrypt 0.3.26 🔵
(ignored)
🔵
(ignored)
destination-redshift 0.3.53
destination-snowflake 0.4.41
destination-tidb 0.1.0
  • See "Actionable Items" below for how to resolve warnings and errors.

👀 Other Modules (1)

  • base-normalization

Actionable Items

(click to expand)

Category Status Actionable Item
Version
mismatch
The version of the connector is different from its normal variant. Please bump the version of the connector.

doc not found
The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like source-jdbc is not published or documented). Please double-check to make sure that it is not a bug.
Changelog
doc not found
The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like source-jdbc is not published or documented). Please double-check to make sure that it is not a bug.

changelog missing
There is no chnagelog for the current version of the connector. If you are the author of the current version, please add a changelog.
Publish
not in seed
The connector is not in the seed file (e.g. source_definitions.yaml), so its publication status cannot be checked. This can be normal (e.g. some connectors are cloud-specific, and only listed in the cloud seed file). Please double-check to make sure that it is not a bug.

diff seed version
The connector exists in the seed file, but the latest version is not listed there. This usually means that the latest version is not published. Please use the /publish command to publish the latest version.

@grishick grishick temporarily deployed to more-secrets December 28, 2022 22:05 — with GitHub Actions Inactive
@grishick grishick force-pushed the greg/databend-destination branch from 5cfbdc4 to b08aa81 Compare December 30, 2022 20:33
@grishick grishick temporarily deployed to more-secrets December 30, 2022 20:35 — with GitHub Actions Inactive
@grishick grishick temporarily deployed to more-secrets December 30, 2022 20:35 — with GitHub Actions Inactive
@grishick

This comment was marked as resolved.

@grishick

This comment was marked as resolved.

@grishick grishick changed the title Greg/databend destination New destination: databend (community PR #19815) Dec 30, 2022
@grishick grishick requested a review from marcosmarxm December 30, 2022 20:50
@grishick grishick force-pushed the greg/databend-destination branch from b08aa81 to 15e2ada Compare December 31, 2022 03:43
@octavia-squidington-iv octavia-squidington-iv removed area/frontend Related to the Airbyte webapp area/platform issues related to the platform labels Dec 31, 2022
@grishick grishick temporarily deployed to more-secrets December 31, 2022 03:45 — with GitHub Actions Inactive
@grishick grishick temporarily deployed to more-secrets December 31, 2022 03:45 — with GitHub Actions Inactive
@grishick

This comment was marked as outdated.

@grishick grishick force-pushed the greg/databend-destination branch from 15e2ada to 8adaad3 Compare January 3, 2023 22:57
@grishick grishick temporarily deployed to more-secrets January 3, 2023 22:59 — with GitHub Actions Inactive
@grishick grishick temporarily deployed to more-secrets January 3, 2023 22:59 — with GitHub Actions Inactive
@grishick grishick temporarily deployed to more-secrets January 6, 2023 18:40 — with GitHub Actions Inactive
@grishick grishick temporarily deployed to more-secrets January 6, 2023 18:40 — with GitHub Actions Inactive
@grishick grishick requested review from etsybaev and itaseskii January 6, 2023 20:48
@grishick
Copy link
Contributor Author

grishick commented Jan 6, 2023

Adding @etsybaev to reviewers as current OC

@grishick
Copy link
Contributor Author

grishick commented Jan 6, 2023

/publish connector=connectors/destination-databend

🕑 Publishing the following connectors:
connectors/destination-databend
https://github.com/airbytehq/airbyte/actions/runs/3858410646


Connector Did it publish? Were definitions generated?
connectors/destination-databend

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@grishick grishick temporarily deployed to more-secrets January 7, 2023 00:05 — with GitHub Actions Inactive
@grishick grishick temporarily deployed to more-secrets January 7, 2023 00:06 — with GitHub Actions Inactive
@grishick grishick temporarily deployed to more-secrets January 7, 2023 00:16 — with GitHub Actions Inactive
@grishick grishick temporarily deployed to more-secrets January 7, 2023 00:16 — with GitHub Actions Inactive
@grishick grishick removed request for etsybaev and a team January 9, 2023 16:44
@sajarin sajarin temporarily deployed to more-secrets January 9, 2023 17:06 — with GitHub Actions Inactive
@sajarin sajarin temporarily deployed to more-secrets January 9, 2023 17:07 — with GitHub Actions Inactive
@grishick grishick temporarily deployed to more-secrets January 9, 2023 17:36 — with GitHub Actions Inactive
@grishick grishick temporarily deployed to more-secrets January 9, 2023 17:37 — with GitHub Actions Inactive
Copy link
Contributor

@natalyjazzviolin natalyjazzviolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@grishick grishick merged commit 56c6864 into master Jan 9, 2023
@grishick grishick deleted the greg/databend-destination branch January 9, 2023 18:19
jbfbell pushed a commit that referenced this pull request Jan 13, 2023
* feat: Add databend destination

Co-authored-by: hantmac <hantmac@outlook.com>
Co-authored-by: josephkmh <joseph@airbyte.io>
Co-authored-by: Sajarin <sajarindider@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/destination/databend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assist Databend destination contribution
7 participants