Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🪟 🧹 Remove <StartWithDestination /> Component #20943

Merged
merged 1 commit into from
Jan 4, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
🪟 🧹 Remove <StartWithDestination /> Component
Removing code related to this experiment as it didn't have any impact
  • Loading branch information
letiescanciano committed Jan 2, 2023
commit 96669ea984de3166fd7ab233e25352274629d1c0

This file was deleted.

Original file line number Diff line number Diff line change
@@ -10,9 +10,7 @@ import { useGetDestinationDefinitionSpecificationAsync } from "services/connecto
import { ConnectorIds } from "utils/connectors";
import { FormError } from "utils/errorStatusMessage";
import { ConnectorCard } from "views/Connector/ConnectorCard";
import { ConnectorCardValues, FrequentlyUsedConnectors, StartWithDestination } from "views/Connector/ConnectorForm";

import styles from "./DestinationForm.module.scss";
import { ConnectorCardValues, FrequentlyUsedConnectors } from "views/Connector/ConnectorForm";

interface DestinationFormProps {
onSubmit: (values: {
@@ -69,29 +67,21 @@ export const DestinationForm: React.FC<DestinationFormProps> = ({ onSubmit, dest
connectorIds={frequentlyUsedDestinationIds}
/>
);
const startWithDestinationComponent = !isLoading && !destinationDefinitionId && (
<div className={styles.startWithDestinationContainer}>
<StartWithDestination onDestinationSelect={onDropDownSelect} availableServices={destinationDefinitions} />
</div>
);

return (
<>
<ConnectorCard
formType="destination"
title={<FormattedMessage id="onboarding.destinationSetUp" />}
description={<FormattedMessage id="destinations.description" />}
isLoading={isLoading}
fetchingConnectorError={destinationDefinitionError instanceof Error ? destinationDefinitionError : null}
availableConnectorDefinitions={destinationDefinitions}
onConnectorDefinitionSelect={onDropDownSelect}
selectedConnectorDefinitionSpecification={destinationDefinitionSpecification}
selectedConnectorDefinitionId={destinationDefinitionId}
onSubmit={onSubmitForm}
jobInfo={LogsRequestError.extractJobInfo(error)}
additionalSelectorComponent={frequentlyUsedDestinationsComponent}
/>
{startWithDestinationComponent}
</>
<ConnectorCard
formType="destination"
title={<FormattedMessage id="onboarding.destinationSetUp" />}
description={<FormattedMessage id="destinations.description" />}
isLoading={isLoading}
fetchingConnectorError={destinationDefinitionError instanceof Error ? destinationDefinitionError : null}
availableConnectorDefinitions={destinationDefinitions}
onConnectorDefinitionSelect={onDropDownSelect}
selectedConnectorDefinitionSpecification={destinationDefinitionSpecification}
selectedConnectorDefinitionId={destinationDefinitionId}
onSubmit={onSubmitForm}
jobInfo={LogsRequestError.extractJobInfo(error)}
additionalSelectorComponent={frequentlyUsedDestinationsComponent}
/>
);
};
Original file line number Diff line number Diff line change
@@ -11,7 +11,6 @@ export interface Experiments {
"connector.inviteUsersHint.linkToUsersPage": boolean;
"connector.orderOverwrite": Record<string, number>;
"connector.frequentlyUsedDestinationIds": string[];
"connector.startWithDestinationId": string;
"connector.form.useDatepicker": boolean;
"authPage.rightSideUrl": string | undefined;
"authPage.hideSelfHostedCTA": boolean;
2 changes: 0 additions & 2 deletions airbyte-webapp/src/locales/en.json
Original file line number Diff line number Diff line change
@@ -325,8 +325,6 @@
"destinations.newDestinationTitle": "New destination",
"destinations.destinationSetUp": "Set up the destination",
"destinations.frequentlyUsed": "Most frequently used destinations",
"destinations.dontHaveYourOwnDestination": "Don’t have your own destination yet?",
"destinations.startWith": "Start with {name}",

"connection.stream.syncMode": "{syncMode} - {destinationSyncMode}",

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

1 change: 0 additions & 1 deletion airbyte-webapp/src/views/Connector/ConnectorForm/index.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
export * from "./types";
export * from "./ConnectorForm";

export { StartWithDestination } from "./components/StartWithDestination";
export { FrequentlyUsedConnectors } from "./components/FrequentlyUsedConnectors";