Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove definitions from getEntityTableData method #20978

Closed

Conversation

krishnaglick
Copy link
Contributor

What

Resolves #20667

How

The icon property is available on the top level source or destination so there was no need to load the source or destination definition.

@krishnaglick krishnaglick requested a review from a team as a code owner January 3, 2023 17:31
@octavia-squidington-iv octavia-squidington-iv added area/platform issues related to the platform area/frontend Related to the Airbyte webapp labels Jan 3, 2023
@krishnaglick krishnaglick changed the title Removes definitions from getEntityTableData method Remove definitions from getEntityTableData method Jan 3, 2023
@krishnaglick
Copy link
Contributor Author

Holidays made me forget that #20264 does this.

@krishnaglick krishnaglick deleted the kc/remove-definitions-from-getEntityTableData branch January 3, 2023 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend Related to the Airbyte webapp area/platform issues related to the platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove calls to "list_by_workspace" and "list_latest" from Sources and Destination list pages
2 participants