Simplify messaging for sync canceled jobs #20999
Conversation
* Hide stats * Show cancelled icon when it's multiple attempts * Update attempts count to gray * Extract shared attempt functions into utils file * Cleanup component export and scss imports * Fix height glitch when opening and closing log
octavia-squidington-iv
added
area/platform
| @@ -44,16 +44,18 @@ | |||
| .attemptCount { | |||
There was a problem hiding this comment.
Nit: we could use the <Text/> component in place of the div wrapping this text to remove the explicit font sizes.
| } | ||
| } | ||
|
|
||
| border-bottom: variables.$border-thin solid transparent !important; |
There was a problem hiding this comment.
Out of curiosity -- is this due to <Row /> having its own border: none; rule in the styled component and it was also broken before?
There was a problem hiding this comment.
@tealjulia Yep that's the reason.
| }; | ||
|
|
||
| const AttemptDetails: React.FC<AttemptDetailsProps> = ({ attempt, className, hasMultipleAttempts }) => { | ||
| export const AttemptDetails: React.FC<AttemptDetailsProps> = ({ attempt, className, hasMultipleAttempts }) => { | ||
| const { formatMessage } = useIntl(); | ||
|
|
||
| if (attempt.status !== AttemptStatus.succeeded && attempt.status !== AttemptStatus.failed) { |
There was a problem hiding this comment.
Not related to these changes... but I'm curious why we don't just check if attempt.status === AttemptStatus.running here. It doesn't look like it's ever null/undefined from the types.
There was a problem hiding this comment.
It just needs to be cleaned up because of changes that were made to get rid of the Status enum which was tracking too many statuses:
https://github.com/airbytehq/airbyte/pull/19599/files#diff-9438e96560c48e89bef8ea05895b60ab0cc824a87ae8408196d4de80a12b4f4aL24
|
nice! looks great. |
* Hide stats * Show cancelled icon when it's multiple attempts * Update attempts count to gray * Extract shared attempt functions into utils file * Cleanup component export and scss imports * Fix height glitch when opening and closing log
What
Resolves #19630
Updates information when a Sync is canceled:
https://www.loom.com/share/26bdb2489be34416aa56e33709ed5a6c
How
Adds more checks. For attempts, it checks if the failure type was a manual cancelation
Misc:
Recommended reading order
From top to bottom