-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move hadoop-lzo to test dependency #21085
Conversation
Affected Connector ReportNOTE
|
Connector | Version | Changelog | Publish |
---|
- See "Actionable Items" below for how to resolve warnings and errors.
✅ Destinations (10)
Connector | Version | Changelog | Publish |
---|---|---|---|
destination-bigquery |
1.2.9 |
✅ | ✅ |
destination-bigquery-denormalized |
1.2.10 |
✅ | ✅ |
destination-databricks |
0.3.1 |
✅ | ✅ |
destination-gcs |
0.2.12 |
✅ | ✅ |
destination-jdbc |
0.3.14 |
🔵 (ignored) |
🔵 (ignored) |
destination-r2 |
0.1.0 |
✅ | ✅ |
destination-redshift |
0.3.53 |
✅ | ✅ |
destination-s3 |
0.3.18 |
✅ | ✅ |
destination-s3-glue |
0.1.1 |
✅ | ✅ |
destination-snowflake |
0.4.41 |
✅ | ✅ |
- See "Actionable Items" below for how to resolve warnings and errors.
✅ Other Modules (0)
Actionable Items
(click to expand)
Category | Status | Actionable Item |
---|---|---|
Version | ❌ mismatch |
The version of the connector is different from its normal variant. Please bump the version of the connector. |
⚠ doc not found |
The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like source-jdbc is not published or documented). Please double-check to make sure that it is not a bug. |
|
Changelog | ⚠ doc not found |
The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like source-jdbc is not published or documented). Please double-check to make sure that it is not a bug. |
❌ changelog missing |
There is no chnagelog for the current version of the connector. If you are the author of the current version, please add a changelog. | |
Publish | ⚠ not in seed |
The connector is not in the seed file (e.g. source_definitions.yaml ), so its publication status cannot be checked. This can be normal (e.g. some connectors are cloud-specific, and only listed in the cloud seed file). Please double-check to make sure that it is not a bug. |
❌ diff seed version |
The connector exists in the seed file, but the latest version is not listed there. This usually means that the latest version is not published. Please use the /publish command to publish the latest version. |
/test connector=connectors/destination-s3 |
/test connector=connectors/destination-bigquery
Build PassedTest summary info:
|
/test connector=connectors/destination-s3
Build PassedTest summary info:
|
/test connector=connectors/destination-gcs
Build PassedTest summary info:
|
/test connector=connectors/destination-snowflake |
destination-s3 run here: https://github.com/airbytehq/airbyte/actions/runs/3851924067/jobs/6563610583 |
/test connector=connectors/destination-redshift
Build PassedTest summary info:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
save us! approved once builds pass!
/test connector=connectors/destination-snowflake
Build PassedTest summary info:
|
* remove hadoop-lzo from gradle dependencies in destination-s3 project * move hadoop-lzo from build time to test time dependencies in base-s3 project
* Revert "Move hadoop-lzo to test dependency (#21085)" This reverts commit 1241569. * add basic test * Automated Change * version bumps, changelog * Automated Change * unused import * Ran ./gradlew :spotlessJavaApply to trigger GitHub build * regenerate registry --------- Co-authored-by: edgao <edgao@users.noreply.github.com> Co-authored-by: ryankfu <ryan.fu@airbyte.io>
* Revert "Move hadoop-lzo to test dependency (#21085)" This reverts commit 1241569. * add basic test * Automated Change * version bumps, changelog * Automated Change * unused import * Ran ./gradlew :spotlessJavaApply to trigger GitHub build * regenerate registry --------- Co-authored-by: edgao <edgao@users.noreply.github.com> Co-authored-by: ryankfu <ryan.fu@airbyte.io>
* Revert "Move hadoop-lzo to test dependency (airbytehq#21085)" This reverts commit 1241569. * add basic test * Automated Change * version bumps, changelog * Automated Change * unused import * Ran ./gradlew :spotlessJavaApply to trigger GitHub build * regenerate registry --------- Co-authored-by: edgao <edgao@users.noreply.github.com> Co-authored-by: ryankfu <ryan.fu@airbyte.io>
What
destination-s3 does not have a direct compile dependency on hadoop-lzo library, so it can be removed