Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move hadoop-lzo to test dependency #21085

Merged
merged 2 commits into from
Jan 6, 2023
Merged

Move hadoop-lzo to test dependency #21085

merged 2 commits into from
Jan 6, 2023

Conversation

grishick
Copy link
Contributor

@grishick grishick commented Jan 5, 2023

What

destination-s3 does not have a direct compile dependency on hadoop-lzo library, so it can be removed

@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2023

Affected Connector Report

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to do the following as needed:

  • Run integration tests
  • Bump connector or module version
  • Add changelog
  • Publish the new version

✅ Sources (0)

Connector Version Changelog Publish
  • See "Actionable Items" below for how to resolve warnings and errors.

✅ Destinations (10)

Connector Version Changelog Publish
destination-bigquery 1.2.9
destination-bigquery-denormalized 1.2.10
destination-databricks 0.3.1
destination-gcs 0.2.12
destination-jdbc 0.3.14 🔵
(ignored)
🔵
(ignored)
destination-r2 0.1.0
destination-redshift 0.3.53
destination-s3 0.3.18
destination-s3-glue 0.1.1
destination-snowflake 0.4.41
  • See "Actionable Items" below for how to resolve warnings and errors.

✅ Other Modules (0)

Actionable Items

(click to expand)

Category Status Actionable Item
Version
mismatch
The version of the connector is different from its normal variant. Please bump the version of the connector.

doc not found
The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like source-jdbc is not published or documented). Please double-check to make sure that it is not a bug.
Changelog
doc not found
The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like source-jdbc is not published or documented). Please double-check to make sure that it is not a bug.

changelog missing
There is no chnagelog for the current version of the connector. If you are the author of the current version, please add a changelog.
Publish
not in seed
The connector is not in the seed file (e.g. source_definitions.yaml), so its publication status cannot be checked. This can be normal (e.g. some connectors are cloud-specific, and only listed in the cloud seed file). Please double-check to make sure that it is not a bug.

diff seed version
The connector exists in the seed file, but the latest version is not listed there. This usually means that the latest version is not published. Please use the /publish command to publish the latest version.

@grishick
Copy link
Contributor Author

grishick commented Jan 6, 2023

/test connector=connectors/destination-s3

@grishick
Copy link
Contributor Author

grishick commented Jan 6, 2023

/test connector=connectors/destination-bigquery

🕑 connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/3851602950
✅ connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/3851602950
Python tests coverage:

Name                                                              Stmts   Miss  Cover
-------------------------------------------------------------------------------------
normalization/transform_config/__init__.py                            2      0   100%
normalization/transform_catalog/reserved_keywords.py                 14      0   100%
normalization/transform_catalog/__init__.py                           2      0   100%
normalization/destination_type.py                                    14      0   100%
normalization/__init__.py                                             4      0   100%
normalization/transform_catalog/destination_name_transformer.py     166      8    95%
normalization/transform_catalog/table_name_registry.py              174     34    80%
normalization/transform_config/transform.py                         189     48    75%
normalization/transform_catalog/utils.py                             51     14    73%
normalization/transform_catalog/dbt_macro.py                         22      7    68%
normalization/transform_catalog/catalog_processor.py                147     80    46%
normalization/transform_catalog/transform.py                         61     38    38%
normalization/transform_catalog/stream_processor.py                 595    400    33%
-------------------------------------------------------------------------------------
TOTAL                                                              1441    629    56%

Build Passed

Test summary info:

All Passed

@grishick
Copy link
Contributor Author

grishick commented Jan 6, 2023

/test connector=connectors/destination-s3

🕑 connectors/destination-s3 https://github.com/airbytehq/airbyte/actions/runs/3851924067
✅ connectors/destination-s3 https://github.com/airbytehq/airbyte/actions/runs/3851924067
No Python unittests run

Build Passed

Test summary info:

All Passed

@grishick
Copy link
Contributor Author

grishick commented Jan 6, 2023

/test connector=connectors/destination-gcs

🕑 connectors/destination-gcs https://github.com/airbytehq/airbyte/actions/runs/3851855616
✅ connectors/destination-gcs https://github.com/airbytehq/airbyte/actions/runs/3851855616
No Python unittests run

Build Passed

Test summary info:

All Passed

@grishick grishick changed the title remove hadoop-lzo from gradle dependencies Move hadoop-lzo to test runtime dependency Jan 6, 2023
@grishick grishick changed the title Move hadoop-lzo to test runtime dependency Move hadoop-lzo to test dependency Jan 6, 2023
@grishick
Copy link
Contributor Author

grishick commented Jan 6, 2023

/test connector=connectors/destination-snowflake

@grishick grishick temporarily deployed to more-secrets January 6, 2023 01:59 — with GitHub Actions Inactive
@grishick
Copy link
Contributor Author

grishick commented Jan 6, 2023

@grishick
Copy link
Contributor Author

grishick commented Jan 6, 2023

/test connector=connectors/destination-redshift

🕑 connectors/destination-redshift https://github.com/airbytehq/airbyte/actions/runs/3851946527
✅ connectors/destination-redshift https://github.com/airbytehq/airbyte/actions/runs/3851946527
Python tests coverage:

Name                                                              Stmts   Miss  Cover
-------------------------------------------------------------------------------------
normalization/transform_config/__init__.py                            2      0   100%
normalization/transform_catalog/reserved_keywords.py                 14      0   100%
normalization/transform_catalog/__init__.py                           2      0   100%
normalization/destination_type.py                                    14      0   100%
normalization/__init__.py                                             4      0   100%
normalization/transform_catalog/destination_name_transformer.py     166      8    95%
normalization/transform_catalog/table_name_registry.py              174     34    80%
normalization/transform_config/transform.py                         189     48    75%
normalization/transform_catalog/utils.py                             51     14    73%
normalization/transform_catalog/dbt_macro.py                         22      7    68%
normalization/transform_catalog/catalog_processor.py                147     80    46%
normalization/transform_catalog/transform.py                         61     38    38%
normalization/transform_catalog/stream_processor.py                 595    400    33%
-------------------------------------------------------------------------------------
TOTAL                                                              1441    629    56%

Build Passed

Test summary info:

All Passed

Copy link
Contributor

@cgardens cgardens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

save us! approved once builds pass!

@grishick
Copy link
Contributor Author

grishick commented Jan 6, 2023

/test connector=connectors/destination-snowflake

🕑 connectors/destination-snowflake https://github.com/airbytehq/airbyte/actions/runs/3857644720
✅ connectors/destination-snowflake https://github.com/airbytehq/airbyte/actions/runs/3857644720
Python tests coverage:

Name                                                              Stmts   Miss  Cover
-------------------------------------------------------------------------------------
normalization/transform_config/__init__.py                            2      0   100%
normalization/transform_catalog/reserved_keywords.py                 14      0   100%
normalization/transform_catalog/__init__.py                           2      0   100%
normalization/destination_type.py                                    14      0   100%
normalization/__init__.py                                             4      0   100%
normalization/transform_catalog/destination_name_transformer.py     166      8    95%
normalization/transform_catalog/table_name_registry.py              174     34    80%
normalization/transform_config/transform.py                         189     48    75%
normalization/transform_catalog/utils.py                             51     14    73%
normalization/transform_catalog/dbt_macro.py                         22      7    68%
normalization/transform_catalog/catalog_processor.py                147     80    46%
normalization/transform_catalog/transform.py                         61     38    38%
normalization/transform_catalog/stream_processor.py                 595    400    33%
-------------------------------------------------------------------------------------
TOTAL                                                              1441    629    56%

Build Passed

Test summary info:

All Passed

@grishick grishick merged commit 1241569 into master Jan 6, 2023
@grishick grishick deleted the greg/remove-hadoop-lzo branch January 6, 2023 20:52
jbfbell pushed a commit that referenced this pull request Jan 13, 2023
* remove hadoop-lzo from gradle dependencies in destination-s3 project
* move hadoop-lzo from build time to test time dependencies in base-s3 project
edgao added a commit that referenced this pull request May 18, 2023
edgao added a commit that referenced this pull request May 22, 2023
* Revert "Move hadoop-lzo to test dependency (#21085)"

This reverts commit 1241569.

* add basic test

* Automated Change

* version bumps, changelog

* Automated Change

* unused import

* Ran ./gradlew :spotlessJavaApply to trigger GitHub build

* regenerate registry

---------

Co-authored-by: edgao <edgao@users.noreply.github.com>
Co-authored-by: ryankfu <ryan.fu@airbyte.io>
nguyenaiden pushed a commit that referenced this pull request May 25, 2023
* Revert "Move hadoop-lzo to test dependency (#21085)"

This reverts commit 1241569.

* add basic test

* Automated Change

* version bumps, changelog

* Automated Change

* unused import

* Ran ./gradlew :spotlessJavaApply to trigger GitHub build

* regenerate registry

---------

Co-authored-by: edgao <edgao@users.noreply.github.com>
Co-authored-by: ryankfu <ryan.fu@airbyte.io>
marcosmarxm pushed a commit to natalia-miinto/airbyte that referenced this pull request Jun 8, 2023
* Revert "Move hadoop-lzo to test dependency (airbytehq#21085)"

This reverts commit 1241569.

* add basic test

* Automated Change

* version bumps, changelog

* Automated Change

* unused import

* Ran ./gradlew :spotlessJavaApply to trigger GitHub build

* regenerate registry

---------

Co-authored-by: edgao <edgao@users.noreply.github.com>
Co-authored-by: ryankfu <ryan.fu@airbyte.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants