Remerge Progress Bar Read API. #21124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octavia-squidington-iv
added
area/platform
davinchia
commented
Jan 6, 2023
| @@ -511,6 +513,76 @@ public AttemptStats getAttemptStats(final long jobId, final int attemptNumber) t | |||
| }); | |||
| } | |||
|
|
|||
| @Override | |||
| public Map<JobAttemptPair, AttemptStats> getAttemptStats(final List<Long> jobIds) throws IOException { | |||
| if (jobIds == null || jobIds.isEmpty()) { | |||
There was a problem hiding this comment.
first change from pre-revert
davinchia
commented
Jan 6, 2023
| @@ -528,6 +600,10 @@ static Long getAttemptId(final long jobId, final int attemptNumber, final DSLCon | |||
| final Optional<Record> record = | |||
| ctx.fetch("SELECT id from attempts where job_id = ? AND attempt_number = ?", jobId, | |||
| attemptNumber).stream().findFirst(); | |||
| if (record.isEmpty()) { | |||
There was a problem hiding this comment.
second change from pre-revert
davinchia
commented
Jan 6, 2023
Comment on lines
+524
to
+532
| @DisplayName("Retrieving stats for an empty list should not cause an exception.") | ||
| void testGetStatsForEmptyJobList() throws IOException { | ||
| assertNotNull(jobPersistence.getAttemptStats(List.of())); | ||
| } | ||
|
|
||
| @Test | ||
| @DisplayName("Retrieving stats for a bad job attempt input should not cause an exception.") | ||
| void testGetStatsForBadJobAttemptInput() throws IOException { | ||
| assertNotNull(jobPersistence.getAttemptStats(-1, -1)); |
pmossman
approved these changes
Jan 6, 2023
jbfbell
pushed a commit
that referenced
this pull request
Jan 13, 2023
Let's try #20937 again, this time with better test for error cases. See original PR for description. This PR adds testing and logic to handle empty/bad job input.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Let's try #20937 again, this time with better test for error cases.
How
See original PR for description.
This PR adds testing and logic to handle empty/bad job input.
Recommended reading order
DefaultJobPersistenceTest.java🚨 User Impact 🚨
Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.
Pre-merge Checklist
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
airbyte_secret./gradlew :airbyte-integrations:connectors:<name>:integrationTest.README.mdbootstrap.md. See description and examplesdocs/integrations/<source or destination>/<name>.mdincluding changelog. See changelog exampledocs/integrations/README.mdairbyte-integrations/builds.mdAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>command is passing/publishcommand described hereUpdating a connector
Community member or Airbyter
airbyte_secret./gradlew :airbyte-integrations:connectors:<name>:integrationTest.README.mdbootstrap.md. See description and examplesdocs/integrations/<source or destination>/<name>.mdincluding changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>command is passing/publishcommand described hereConnector Generator
-scaffoldin their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplatesthen checking in your changesTests
Unit
Put your unit tests output here.
Integration
Put your integration tests output here.
Acceptance
Put your acceptance tests output here.