Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce HTTPS #21182

Merged
merged 2 commits into from
Jan 11, 2023
Merged

Enforce HTTPS #21182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b474223
Enforce HTTPS
Jan 10, 2023
402d898
Fix unit tests
Jan 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/destination-databend/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,5 +34,5 @@ COPY destination_databend ./destination_databend
ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]

LABEL io.airbyte.version=0.1.0
LABEL io.airbyte.version=0.1.1
LABEL io.airbyte.name=airbyte/destination-databend
5 changes: 2 additions & 3 deletions airbyte-integrations/connectors/destination-databend/destination_databend/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,7 @@


class DatabendClient:
def __init__(self, protocol: str, host: str, port: int, database: str, table: str, username: str, password: str = None):
self.protocol = protocol
def __init__(self, host: str, port: int, database: str, table: str, username: str, password: str = None):
self.host = host
self.port = port
self.database = database
Expand All @@ -16,6 +15,6 @@ def __init__(self, protocol: str, host: str, port: int, database: str, table: st
self.password = password

def open(self):
handle = connector.connect(f"{self.protocol}://{self.username}:{self.password}@{self.host}:{self.port}").cursor()
handle = connector.connect(f"https://{self.username}:{self.password}@{self.host}:{self.port}").cursor()

return handle
10 changes: 0 additions & 10 deletions airbyte-integrations/connectors/destination-databend/destination_databend/spec.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,16 +24,6 @@
"type" : "string",
"order" : 0
},
"protocol" : {
"title" : "Protocol",
"description" : "Protocol of the host.",
"type" : "string",
"examples" : [
"https"
],
"default" : "https",
"order" : 1
},
"port" : {
"title" : "Port",
"description" : "Port of the database.",
Expand Down
1 change: 0 additions & 1 deletion airbyte-integrations/connectors/destination-databend/unit_tests/test_databend_destination.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ def config() -> Dict[str, str]:
"username": "root",
"password": "root",
"host": "localhost",
"protocol": "http",
"port": 8081,
"table": "default",
}
Expand Down
7 changes: 6 additions & 1 deletion docs/integrations/destinations/databend.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,4 +51,9 @@ You should now have all the requirements needed to configure Databend as a desti


## Changelog
######TODO: more info

| Version | Date | Pull Request | Subject |
|:--------|:-----------|:---------------------------------------------------------|:-----------------------------------------|
| 0.1.1 | 2022-01-09 | [21182](https://github.com/airbytehq/airbyte/pull/21182) | Remove protocol option and enforce HTTPS |
| 0.1.0 | 2022-01-09 | [20909](https://github.com/airbytehq/airbyte/pull/20909) | Destination Databend |