Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bmoric/restore old interface #21235

Merged
merged 3 commits into from
Jan 11, 2023
Merged

Bmoric/restore old interface #21235

merged 3 commits into from
Jan 11, 2023

Conversation

benmoriceau
Copy link
Contributor

What

After bumping that oss version that contains the micronaut migration of the oss server, we ran into issue such as A provider io.airbyte.server.errors.InvalidInputExceptionMapper registered in SERVER runtime does not implement any provider interfaces applicable in the SERVER runtime. Due to constraint configuration problems the provider io.airbyte.server.errors.InvalidInputExceptionMapper will be ignored.

In order to avoid having those mapper to not be present, we need to re-introduce the old mappers even if they are not being used in the OSS project anymore.

Copy link
Member

@colesnodgrass colesnodgrass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is also making changes to existing files and is not just re-introducing removed files. Is there a way to differentiate between the two cases or do we need to undo all of the Micronaut Mapper changes?

@benmoriceau
Copy link
Contributor Author

This PR is also making changes to existing files and is not just re-introducing removed files. Is there a way to differentiate between the two cases or do we need to undo all of the Micronaut Mapper changes?

The Mapper are restoring what they used to be before migration and the micronaut migration now goes into handlers. The file were not remove but re-implemented :/

@benmoriceau benmoriceau temporarily deployed to more-secrets January 11, 2023 16:20 — with GitHub Actions Inactive
@benmoriceau benmoriceau temporarily deployed to more-secrets January 11, 2023 16:20 — with GitHub Actions Inactive
@benmoriceau benmoriceau merged commit 449b252 into master Jan 11, 2023
@benmoriceau benmoriceau deleted the bmoric/restore-old-interface branch January 11, 2023 16:56
jbfbell pushed a commit that referenced this pull request Jan 13, 2023
* Re introduce old exception mapper

* Use mapper
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/platform issues related to the platform area/server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants