Ensure Local Secret Persistence is Initialized #21329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdpgrailsdev
requested review from
colesnodgrass,
gosusnp,
benmoriceau,
davinchia and
alovew
jdpgrailsdev
changed the title
benmoriceau
approved these changes
Jan 12, 2023
| @@ -35,7 +35,7 @@ services: | |||
| - airbyte/server:${ALT_TAG:-${VERSION}} | |||
| platforms: | |||
| - linux/amd64 | |||
| - linux/arm64 | |||
| - linux/arm64 | |||
There was a problem hiding this comment.
is this duplication needed?
There was a problem hiding this comment.
@benmoriceau Could you be more specific? The two entries are different (amd64 vs arm64)
jdpgrailsdev
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
jdpgrailsdev
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
colesnodgrass
approved these changes
Jan 12, 2023
davinchia
approved these changes
Jan 12, 2023
jbfbell
pushed a commit
that referenced
this pull request
Jan 13, 2023
* Formatting * Ensure that local persistence is initialized
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
How
intialize()before read/writeRecommended reading order
LocalTestingSecretPersistence.java