fix: Introduces back the `initial_waiting_seconds` option for MSSQL source. #21348

sergio-ropero · 2023-01-12T20:14:03Z

What

The option initial_waiting_seconds was removed accidentally on PR #18959.
See issue: #21191

How

Rolling back the initial_waiting_seconds related part on above mentioned PR and adding a value to the expected_spec.json file.

🚨 User Impact 🚨

Users were not able to add a delay when setting a connection between MSSQL and any destination.

UI Changes

Version 0.4.26 (master version)

Version 0.4.27 (dev version)

CLAassistant · 2023-01-12T20:14:10Z

All committers have signed the CLA.

github-actions · 2023-01-12T20:15:56Z

Affected Connector Report

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to do the following as needed:

Run integration tests
Bump connector or module version
Add changelog
Publish the new version

✅ Sources (2)

Connector	Version	Changelog	Publish
`source-mssql`	`0.4.28`	✅	✅
`source-mssql-strict-encrypt`	`0.4.28`	🔵 (ignored)	🔵 (ignored)

See "Actionable Items" below for how to resolve warnings and errors.

✅ Destinations (0)

Connector	Version	Changelog	Publish

See "Actionable Items" below for how to resolve warnings and errors.

✅ Other Modules (0)

Actionable Items

(click to expand)

Category	Status	Actionable Item
Version	❌ mismatch	The version of the connector is different from its normal variant. Please bump the version of the connector.
	⚠ doc not found	The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like `source-jdbc` is not published or documented). Please double-check to make sure that it is not a bug.
Changelog	⚠ doc not found	The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like `source-jdbc` is not published or documented). Please double-check to make sure that it is not a bug.
	❌ changelog missing	There is no chnagelog for the current version of the connector. If you are the author of the current version, please add a changelog.
Publish	⚠ not in seed	The connector is not in the seed file (e.g. `source_definitions.yaml`), so its publication status cannot be checked. This can be normal (e.g. some connectors are cloud-specific, and only listed in the cloud seed file). Please double-check to make sure that it is not a bug.
	❌ diff seed version	The connector exists in the seed file, but the latest version is not listed there. This usually means that the latest version is not published. Please use the `/publish` command to publish the latest version.

sergio-ropero · 2023-01-12T20:17:22Z

/test connector=connectors/source-mssql

🕑 connectors/source-mssql https://github.com/airbytehq/airbyte/actions/runs/3905725921
❌ connectors/source-mssql https://github.com/airbytehq/airbyte/actions/runs/3905725921
🐛 https://gradle.com/s/kaylm2tlzbud6

Build Failed

Test summary info:

Could not find result summary

subodh1810 · 2023-01-16T11:18:30Z

/test connector=connectors/source-mssql-strict-encrypt

🕑 connectors/source-mssql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/3929845689
❌ connectors/source-mssql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/3929845689
🐛 https://gradle.com/s/c42wv6lfemong

Build Failed

Test summary info:

Could not find result summary

…waiting-seconds' into sergio-ropero/fix/mssql-initial-waiting-seconds

…conds

sergio-ropero · 2023-01-16T15:09:02Z

/test connector=connectors/source-mssql-strict-encrypt

🕑 connectors/source-mssql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/3931653125
❌ connectors/source-mssql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/3931653125
🐛 https://gradle.com/s/wt6jpzxbc3z24

Build Failed

Test summary info:

Could not find result summary

…conds

sergio-ropero · 2023-01-17T10:42:18Z

/test connector=connectors/source-mssql

🕑 connectors/source-mssql https://github.com/airbytehq/airbyte/actions/runs/3938435769
❌ connectors/source-mssql https://github.com/airbytehq/airbyte/actions/runs/3938435769
🐛 https://gradle.com/s/nsk46zhh3j43a

Build Failed

Test summary info:

Could not find result summary

sergio-ropero · 2023-01-17T18:39:08Z

/test connector=connectors/source-mssql-strict-encrypt

🕑 connectors/source-mssql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/3942272422
✅ connectors/source-mssql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/3942272422
No Python unittests run

Build Passed

Test summary info:

All Passed

…conds

sergio-ropero · 2023-01-18T11:41:14Z

/test connector=connectors/source-mssql

🕑 connectors/source-mssql https://github.com/airbytehq/airbyte/actions/runs/3948501882
✅ connectors/source-mssql https://github.com/airbytehq/airbyte/actions/runs/3948501882
Python tests coverage:

	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       141      5    96%   87, 93, 239, 243-244
	 source_acceptance_test/conftest.py                     211     95    55%   36, 42-44, 49, 54, 77, 83, 89-91, 110, 115-117, 123-125, 131-132, 137-138, 143, 149, 158-167, 173-178, 193, 217, 248, 254, 262-267, 275-285, 293-306, 311-317, 324-335, 342-358
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              402    115    71%   53, 58, 93-104, 109-116, 120-121, 125-126, 308, 346-363, 376-387, 391-396, 402, 435-440, 478-485, 528-530, 533, 598-606, 618-621, 626, 682-683, 689, 692, 728-738, 751-776
	 source_acceptance_test/tests/test_incremental.py       160     14    91%   58-65, 70-83, 246
	 source_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       133     33    75%   24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208
	 source_acceptance_test/utils/json_schema_helper.py     107     13    88%   30-31, 38, 41, 65-68, 96, 120, 192-194
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1609    339    79%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestConnection.test_check: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestDiscovery.test_discover: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestBasicRead.test_read: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestFullRefresh.test_sequential_reads: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: not found in the config.
================= 14 passed, 5 skipped, 21 warnings in 24.05s ==================

sergio-ropero · 2023-01-18T13:49:35Z

/publish connector=connectors/source-mssql-strict-encrypt

🕑 Publishing the following connectors:
connectors/source-mssql-strict-encrypt
https://github.com/airbytehq/airbyte/actions/runs/3949506208

Connector	Did it publish?	Were definitions generated?
connectors/source-mssql-strict-encrypt	❌	❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

…conds

…urce-mssql-strict-encrypt`

…conds

Introduces back the initial_waiting_seconds option for MSSQL source.

888ab7c

sergio-ropero requested a review from a team as a code owner January 12, 2023 20:14

octavia-squidington-iv added the area/connectors Connector related issues label Jan 12, 2023

sergio-ropero requested a review from subodh1810 January 12, 2023 20:14

octavia-squidington-iv added connectors/source/mssql connectors/source/mssql-strict-encrypt labels Jan 12, 2023

sergio-ropero requested review from rodireich and removed request for a team January 12, 2023 20:14

rodireich approved these changes Jan 12, 2023

View reviewed changes

Adds version to documentation

7a2d9dc

octavia-squidington-iv added the area/documentation Improvements or additions to documentation label Jan 12, 2023

Fix copy-paste issue

9ecba26

Sergio Ropero and others added 4 commits January 16, 2023 15:57

Fix expected spec file to match expectations in the integration test.

d3cdc0c

Merge remote-tracking branch 'origin/sergio-ropero/fix/mssql-initial-…

3651748

…waiting-seconds' into sergio-ropero/fix/mssql-initial-waiting-seconds

Add back deleted options

ce9db1e

Merge branch 'master' into sergio-ropero/fix/mssql-initial-waiting-se…

a6e0ed1

…conds

Sergio Ropero and others added 2 commits January 17, 2023 11:41

Add initial_waiting_seconds to strict encrypt expected_spec.json

b9e0cf7

Merge branch 'master' into sergio-ropero/fix/mssql-initial-waiting-se…

f5321fc

…conds

Merge branch 'master' into sergio-ropero/fix/mssql-initial-waiting-se…

f8f0353

…conds

sergio-ropero and others added 2 commits January 18, 2023 15:01

Merge branch 'master' into sergio-ropero/fix/mssql-initial-waiting-se…

e630f20

…conds

fix error with non-matching versioning between source-mssql and `so…

26ee714

…urce-mssql-strict-encrypt`

Merge branch 'master' into sergio-ropero/fix/mssql-initial-waiting-se…

87da189

…conds

sergio-ropero temporarily deployed to more-secrets January 19, 2023 18:19 — with GitHub Actions Inactive

sergio-ropero temporarily deployed to more-secrets January 19, 2023 18:21 — with GitHub Actions Inactive

Merge branch 'master' into sergio-ropero/fix/mssql-initial-waiting-se…

b982842

…conds

sergio-ropero temporarily deployed to more-secrets January 19, 2023 19:01 — with GitHub Actions Inactive

sergio-ropero temporarily deployed to more-secrets January 19, 2023 19:02 — with GitHub Actions Inactive

Merge branch 'master' into sergio-ropero/fix/mssql-initial-waiting-se…

3bf6c17

…conds

sergio-ropero temporarily deployed to more-secrets January 20, 2023 09:03 — with GitHub Actions Inactive

sergio-ropero temporarily deployed to more-secrets January 20, 2023 09:04 — with GitHub Actions Inactive

Merge branch 'master' into sergio-ropero/fix/mssql-initial-waiting-se…

2a6708c

…conds

sergio-ropero temporarily deployed to more-secrets January 20, 2023 09:14 — with GitHub Actions Inactive

sergio-ropero temporarily deployed to more-secrets January 20, 2023 09:55 — with GitHub Actions Inactive

sergio-ropero temporarily deployed to more-secrets January 20, 2023 10:30 — with GitHub Actions Inactive

sergio-ropero temporarily deployed to more-secrets January 20, 2023 10:33 — with GitHub Actions Inactive

Merge branch 'master' into sergio-ropero/fix/mssql-initial-waiting-se…

9baf53e

…conds

sergio-ropero temporarily deployed to more-secrets January 20, 2023 13:40 — with GitHub Actions Inactive

Merge branch 'master' into sergio-ropero/fix/mssql-initial-waiting-se…

e0e3049

…conds

sergio-ropero temporarily deployed to more-secrets January 20, 2023 14:57 — with GitHub Actions Inactive

Merge branch 'master' into sergio-ropero/fix/mssql-initial-waiting-se…

7400fd6

…conds

sergio-ropero temporarily deployed to more-secrets January 23, 2023 11:01 — with GitHub Actions Inactive

sergio-ropero merged commit dd0706e into master Jan 23, 2023

sergio-ropero deleted the sergio-ropero/fix/mssql-initial-waiting-seconds branch January 23, 2023 13:36

octavia-squidington-iii mentioned this pull request Jan 24, 2023

Bump Airbyte version from 0.40.28 to 0.40.29 #21767

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Introduces back the `initial_waiting_seconds` option for MSSQL source. #21348

fix: Introduces back the `initial_waiting_seconds` option for MSSQL source. #21348

sergio-ropero commented Jan 12, 2023 •

edited

Loading

CLAassistant commented Jan 12, 2023 •

edited

Loading

github-actions bot commented Jan 12, 2023 •

edited

Loading

✅ Sources (2)

✅ Destinations (0)

✅ Other Modules (0)

Actionable Items

sergio-ropero commented Jan 12, 2023 •

edited by github-actions bot

Loading

subodh1810 commented Jan 16, 2023 •

edited by github-actions bot

Loading

sergio-ropero commented Jan 16, 2023 •

edited by github-actions bot

Loading

sergio-ropero commented Jan 17, 2023 •

edited by github-actions bot

Loading

sergio-ropero commented Jan 17, 2023 •

edited by github-actions bot

Loading

sergio-ropero commented Jan 18, 2023 •

edited by github-actions bot

Loading

sergio-ropero commented Jan 18, 2023 •

edited by github-actions bot

Loading

fix: Introduces back the initial_waiting_seconds option for MSSQL source. #21348

fix: Introduces back the initial_waiting_seconds option for MSSQL source. #21348

Conversation

sergio-ropero commented Jan 12, 2023 • edited Loading

What

How

Recommended reading order

🚨 User Impact 🚨

UI Changes

Version 0.4.26 (master version)

Version 0.4.27 (dev version)

CLAassistant commented Jan 12, 2023 • edited Loading

github-actions bot commented Jan 12, 2023 • edited Loading

Affected Connector Report

✅ Sources (2)

✅ Destinations (0)

✅ Other Modules (0)

Actionable Items

sergio-ropero commented Jan 12, 2023 • edited by github-actions bot Loading

Build Failed

subodh1810 commented Jan 16, 2023 • edited by github-actions bot Loading

Build Failed

sergio-ropero commented Jan 16, 2023 • edited by github-actions bot Loading

Build Failed

sergio-ropero commented Jan 17, 2023 • edited by github-actions bot Loading

Build Failed

sergio-ropero commented Jan 17, 2023 • edited by github-actions bot Loading

Build Passed

sergio-ropero commented Jan 18, 2023 • edited by github-actions bot Loading

Build Passed

sergio-ropero commented Jan 18, 2023 • edited by github-actions bot Loading

fix: Introduces back the `initial_waiting_seconds` option for MSSQL source. #21348

fix: Introduces back the `initial_waiting_seconds` option for MSSQL source. #21348

sergio-ropero commented Jan 12, 2023 •

edited

Loading

CLAassistant commented Jan 12, 2023 •

edited

Loading

github-actions bot commented Jan 12, 2023 •

edited

Loading

sergio-ropero commented Jan 12, 2023 •

edited by github-actions bot

Loading

subodh1810 commented Jan 16, 2023 •

edited by github-actions bot

Loading

sergio-ropero commented Jan 16, 2023 •

edited by github-actions bot

Loading

sergio-ropero commented Jan 17, 2023 •

edited by github-actions bot

Loading

sergio-ropero commented Jan 17, 2023 •

edited by github-actions bot

Loading

sergio-ropero commented Jan 18, 2023 •

edited by github-actions bot

Loading

sergio-ropero commented Jan 18, 2023 •

edited by github-actions bot

Loading