Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List workspaces with most recently running jobs #21633

Merged
merged 15 commits into from
Jan 26, 2023
Merged

List workspaces with most recently running jobs #21633

merged 15 commits into from
Jan 26, 2023

Conversation

keyihuang
Copy link
Contributor

@keyihuang keyihuang commented Jan 20, 2023 •
edited
Loading

PR status:

Dev work is done & PR is under review

Related PR:

https://github.com/airbytehq/airbyte-cloud/pull/4116

What

This is to enhance the efficiency of DelinquentWorkspaceCronJob in airbyte-cloud/billing.

How

Instead of running the DelinquentWorkspaceCronJob for all workspaces, now we want to focus on the workspaces with most recently running jobs (e.g. in the last 48 hours)

Recommended reading order

  1. airbyte-config/config-persistence/src/main/java/io/airbyte/config/persistence/ConfigRepository.java
  2. test files

Can this PR be safely reverted / rolled back?

  • YES 💚
  • NO ❌

@CLAassistant
Copy link

CLAassistant commented Jan 20, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@keyihuang keyihuang temporarily deployed to more-secrets January 20, 2023 05:29 — with GitHub Actions Inactive
@keyihuang keyihuang temporarily deployed to more-secrets January 20, 2023 05:29 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Jan 20, 2023 •
edited
Loading

Airbyte Code Coverage

File Coverage [81.87%] 🍏
ConfigRepository.java 81.87% 🍏
Total Project Coverage 23.99% ❌

@keyihuang keyihuang temporarily deployed to more-secrets January 20, 2023 05:51 — with GitHub Actions Inactive
@keyihuang keyihuang temporarily deployed to more-secrets January 20, 2023 05:51 — with GitHub Actions Inactive
@keyihuang keyihuang requested a review from xiaohansong January 20, 2023 17:52
xiaohansong
xiaohansong requested changes Jan 20, 2023
View reviewed changes
Copy link
Contributor

@xiaohansong xiaohansong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Can we add a test on this?

...-config/config-persistence/src/main/java/io/airbyte/config/persistence/ConfigRepository.java Outdated Show resolved Hide resolved
@keyihuang keyihuang marked this pull request as ready for review January 23, 2023 18:39
@keyihuang keyihuang requested a review from a team as a code owner January 23, 2023 18:39
@keyihuang keyihuang requested a review from xiaohansong January 23, 2023 18:39
@keyihuang keyihuang temporarily deployed to more-secrets January 23, 2023 18:39 — with GitHub Actions Inactive
@keyihuang keyihuang temporarily deployed to more-secrets January 23, 2023 18:39 — with GitHub Actions Inactive
xiaohansong
xiaohansong approved these changes Jan 23, 2023
View reviewed changes
Copy link
Contributor

@xiaohansong xiaohansong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Leaving two comments for the test and once fixed this is approved

@keyihuang keyihuang temporarily deployed to more-secrets January 23, 2023 19:25 — with GitHub Actions Inactive
@keyihuang keyihuang temporarily deployed to more-secrets January 23, 2023 19:26 — with GitHub Actions Inactive
@keyihuang keyihuang temporarily deployed to more-secrets January 23, 2023 19:28 — with GitHub Actions Inactive
@keyihuang keyihuang temporarily deployed to more-secrets January 23, 2023 19:28 — with GitHub Actions Inactive
@keyihuang keyihuang temporarily deployed to more-secrets January 23, 2023 19:51 — with GitHub Actions Inactive
@keyihuang keyihuang temporarily deployed to more-secrets January 23, 2023 19:51 — with GitHub Actions Inactive
@keyihuang keyihuang temporarily deployed to more-secrets January 23, 2023 19:54 — with GitHub Actions Inactive
@keyihuang keyihuang temporarily deployed to more-secrets January 23, 2023 21:21 — with GitHub Actions Inactive
@keyihuang keyihuang temporarily deployed to more-secrets January 23, 2023 21:21 — with GitHub Actions Inactive
@keyihuang keyihuang self-assigned this Jan 24, 2023
@keyihuang keyihuang temporarily deployed to more-secrets January 24, 2023 21:08 — with GitHub Actions Inactive
@keyihuang keyihuang temporarily deployed to more-secrets January 24, 2023 21:08 — with GitHub Actions Inactive
@keyihuang keyihuang temporarily deployed to more-secrets January 24, 2023 22:53 — with GitHub Actions Inactive
@keyihuang keyihuang temporarily deployed to more-secrets January 24, 2023 22:53 — with GitHub Actions Inactive
@keyihuang keyihuang temporarily deployed to more-secrets January 24, 2023 23:05 — with GitHub Actions Inactive
@keyihuang keyihuang temporarily deployed to more-secrets January 24, 2023 23:05 — with GitHub Actions Inactive
@keyihuang keyihuang temporarily deployed to more-secrets January 24, 2023 23:16 — with GitHub Actions Inactive
@keyihuang keyihuang temporarily deployed to more-secrets January 24, 2023 23:16 — with GitHub Actions Inactive
@keyihuang keyihuang temporarily deployed to more-secrets January 24, 2023 23:57 — with GitHub Actions Inactive
@keyihuang keyihuang temporarily deployed to more-secrets January 24, 2023 23:57 — with GitHub Actions Inactive
@keyihuang keyihuang temporarily deployed to more-secrets January 25, 2023 00:28 — with GitHub Actions Inactive
@keyihuang keyihuang temporarily deployed to more-secrets January 25, 2023 00:28 — with GitHub Actions Inactive
@keyihuang keyihuang temporarily deployed to more-secrets January 26, 2023 01:48 — with GitHub Actions Inactive
@keyihuang keyihuang temporarily deployed to more-secrets January 26, 2023 01:48 — with GitHub Actions Inactive
@keyihuang keyihuang merged commit 6f6b62a into master Jan 26, 2023
@keyihuang keyihuang deleted the keyi/workspace-filter branch January 26, 2023 20:04
This was referenced Jan 27, 2023
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaohansong xiaohansong xiaohansong approved these changes

Assignees

@keyihuang keyihuang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@keyihuang @CLAassistant @xiaohansong