Github Action to enforce allowed hosts are set for GA and Beta connectors #21684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evantahler
commented
Jan 21, 2023
tools/ci_connector_ops/ci_connector_ops/allowed_hosts_checks.py
Outdated
Show resolved
Hide resolved
evantahler
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
evantahler
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
evantahler
changed the title
evantahler
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
evantahler
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
evantahler
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
evantahler
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
Airbyte Code Coverage
|
alafanechere
approved these changes
Jan 23, 2023
There was a problem hiding this comment.
Nice! I only have a couple of minor suggestions.
I think we might want to eventually move this to a QA check as part of /test. This module is ready to welcome it if you like:
https://github.com/airbytehq/airbyte/blob/master/tools/ci_connector_ops/ci_connector_ops/qa_checks.py#L71
But as it is release stage specific check I'm fine keeping it here 👍
tools/ci_connector_ops/ci_connector_ops/allowed_hosts_checks.py
Outdated
Show resolved
Hide resolved
tools/ci_connector_ops/ci_connector_ops/allowed_hosts_checks.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Augustin <augustin@airbyte.io>
evantahler
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
evantahler
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
octavia-squidington-iv
added
the
area/documentation
evantahler
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
evantahler
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
evantahler
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
evantahler
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
erohmensing
approved these changes
Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a check to the renamed
Connector Ops CI - Connector Metadata Checksto ensure that GA connectors includeallowed_hostsin their actor definition.Requires #21676 to be merged first
Closes #21184