Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Low Code CDK: DpathExtractor extend #21690

Merged
merged 7 commits into from
Jan 25, 2023

Conversation

artem1205
Copy link
Collaborator

@artem1205 artem1205 commented Jan 21, 2023

What

Parse responses with nested lists (see tests)
Resolving #20225

Complex response structure connectors:

  1. ChargeBee
  2. Facebook Pages
  3. Monday

How

Use dpath.util.values in DpathExtractor

Recommended reading order

  1. y.python

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

@artem1205 artem1205 requested a review from a team as a code owner January 21, 2023 20:51
@octavia-squidington-iv octavia-squidington-iv added the CDK Connector Development Kit label Jan 21, 2023
Copy link
Contributor

@sherifnada sherifnada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! could you update the docs to describe how the DpathExtractor now works? specifically, we should tell users that * can be used to mean "for each element in the array"

@artem1205 artem1205 requested a review from sherifnada January 24, 2023 09:22
@octavia-squidington-iv octavia-squidington-iv added the area/documentation Improvements or additions to documentation label Jan 24, 2023
Copy link
Contributor

@girarda girarda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 🚢 🚢

@@ -152,6 +153,50 @@ The selected records will be
]
```

### Selecting nested field
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Selecting nested field
### Selecting fields nested in arrays

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

Copy link
Contributor

@sherifnada sherifnada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

Copy link
Contributor

@brianjlai brianjlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@artem1205 changes look good to me. However, we've modified the release process of the airbyte-cdk package a little bit.

We're starting the process a bit. Instead of writing the changelog and bumping the version, we use the "Publish CDK Manually" Github action point it towards your branch, your commit hash, and including the minor bump w/ the changelog message. If you don't have access, we can trigger the workflow once you remove your code on the CHANGELOG.md which will push a commit w/ the version bumps to your current branch

@girarda girarda mentioned this pull request Jan 25, 2023
14 tasks
@artem1205
Copy link
Collaborator Author

@brianjlai , I've removed my code from the CHANGELOG.md.
As I understood, I need to merge this PR now, and then run the Publish CDK Manually Action?
image

@artem1205 artem1205 merged commit e0e83e2 into master Jan 25, 2023
@artem1205 artem1205 deleted the artem1205/airbyte-cdk-lowcode-DpathExtractorValues branch January 25, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation CDK Connector Development Kit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants