-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Low Code CDK: DpathExtractor extend #21690
Low Code CDK: DpathExtractor extend #21690
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! could you update the docs to describe how the DpathExtractor
now works? specifically, we should tell users that *
can be used to mean "for each element in the array"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢 🚢 🚢
@@ -152,6 +153,50 @@ The selected records will be | |||
] | |||
``` | |||
|
|||
### Selecting nested field |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
### Selecting nested field | |
### Selecting fields nested in arrays |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@artem1205 changes look good to me. However, we've modified the release process of the airbyte-cdk
package a little bit.
We're starting the process a bit. Instead of writing the changelog and bumping the version, we use the "Publish CDK Manually" Github action point it towards your branch, your commit hash, and including the minor bump w/ the changelog message. If you don't have access, we can trigger the workflow once you remove your code on the CHANGELOG.md
which will push a commit w/ the version bumps to your current branch
@brianjlai , I've removed my code from the |
What
Parse responses with nested lists (see tests)
Resolving #20225
Complex response structure connectors:
How
Use dpath.util.values in DpathExtractor
Recommended reading order
y.python
🚨 User Impact 🚨
Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.
Pre-merge Checklist
Expand the relevant checklist and delete the others.
Updating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described here