Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename all lowcode connector manifest files to manifest.yaml #21771

Merged
merged 5 commits into from
Jan 25, 2023
Merged

Rename all lowcode connector manifest files to manifest.yaml #21771

merged 5 commits into from
Jan 25, 2023

Conversation

sherifnada
Copy link
Contributor

@sherifnada sherifnada commented Jan 24, 2023 •
edited
Loading

What

Following up on #21770 -- applies that change to all lowcode connectors

I've spotchecked a few connectors and this rename seems to work. It was applied via a script so it should be uniform across the board.

for each connector, the only changes is that we change the yaml manifest name from source_<name>.yaml to manifest.yaml, and we change source.py to load that file instead of source_<name>.yaml.

I don't think a connector publish is needed

@sherifnada sherifnada requested a review from a team as a code owner January 24, 2023 06:15
@sherifnada sherifnada changed the title Sherif/rename connector names Rename all lowcode connector manifest files to manifest.yaml Jan 24, 2023
@sherifnada sherifnada removed the request for review from a team January 24, 2023 06:15
@sherifnada sherifnada changed the base branch from master to sherif/manifestyamlnaming January 24, 2023 06:20
@sherifnada sherifnada mentioned this pull request Jan 24, 2023
Merged
maxi297
maxi297 approved these changes Jan 25, 2023
View reviewed changes
Copy link
Contributor

@maxi297 maxi297 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM minus the migration script in the Zoom source

airbyte-integrations/connectors/source-zoom/source_zoom/source.py Outdated



x=["airbyte-integrations/connectors/source-activecampaign/source_activecampaign/source.py",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems odd. Why is this part of the zoom source?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because I forgot to remove it :D

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Base automatically changed from sherif/manifestyamlnaming to master January 25, 2023 21:08
@sherifnada sherifnada enabled auto-merge (squash) January 25, 2023 21:09
@sherifnada
Copy link
Contributor Author

/approve-and-merge reason="this is a very cosmetic change that touches ~100 connectors. PR checks fail because SATs aren't passing for all these connectors. It is far beyond the scope of this PR to fix all those. "

@sherifnada sherifnada disabled auto-merge January 25, 2023 21:15
@sherifnada sherifnada merged commit 7a403bb into master Jan 25, 2023
@sherifnada sherifnada deleted the sherif/rename-connector-names branch January 25, 2023 21:16
@github-actions github-actions bot mentioned this pull request Jan 25, 2023
Closed
This was referenced Jan 26, 2023
Merged
Merged
This was referenced Jan 27, 2023
Closed
Closed
Merged
@flash1293 flash1293 mentioned this pull request Feb 2, 2023
Merged
@sherifnada sherifnada mentioned this pull request Feb 11, 2023
Merged
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxi297 maxi297 maxi297 approved these changes

@brianjlai brianjlai Awaiting requested review from brianjlai

Assignees
No one assigned
Labels
area/connectors Connector related issues connectors/source/activecampaign connectors/source/aha connectors/source/alpha-vantage connectors/source/ashby connectors/source/braze connectors/source/breezometer connectors/source/callrail connectors/source/chartmogul connectors/source/clickup-api connectors/source/close-com connectors/source/coin-api connectors/source/coinmarketcap connectors/source/configcat connectors/source/convertkit connectors/source/courier connectors/source/datascope connectors/source/dremio connectors/source/emailoctopus connectors/source/facebook-pages connectors/source/getlago connectors/source/gnews connectors/source/gocardless connectors/source/gong connectors/source/google-pagespeed-insights connectors/source/google-webfonts connectors/source/greenhouse connectors/source/gutendex connectors/source/instatus connectors/source/intruder connectors/source/ip2whois connectors/source/k6-cloud connectors/source/launchdarkly connectors/source/lokalise connectors/source/mailerlite connectors/source/mailersend connectors/source/mailjet-mail connectors/source/mailjet-sms connectors/source/metabase connectors/source/monday connectors/source/n8n connectors/source/news-api connectors/source/newsdata connectors/source/nytimes connectors/source/omnisend connectors/source/oura connectors/source/partnerstack connectors/source/pexels-api connectors/source/plausible connectors/source/pocket connectors/source/polygon-stock-api connectors/source/posthog connectors/source/postmarkapp connectors/source/prestashop connectors/source/punk-api connectors/source/pypi connectors/source/recreation connectors/source/recruitee connectors/source/reply-io connectors/source/rocket-chat connectors/source/sap-fieldglass connectors/source/secoda connectors/source/sendinblue connectors/source/senseforce connectors/source/smaily connectors/source/smartengage connectors/source/sonar-cloud connectors/source/spacex-api connectors/source/square connectors/source/statuspage connectors/source/survey-sparrow connectors/source/the-guardian-api connectors/source/tmdb connectors/source/toggl connectors/source/tvmaze-schedule connectors/source/twilio-taskrouter connectors/source/twitter connectors/source/tyntec-sms connectors/source/vantage connectors/source/vitally connectors/source/waiteraid connectors/source/whisky-hunter connectors/source/wikipedia-pageviews connectors/source/woocommerce connectors/source/workable connectors/source/workramp connectors/source/zapier-supported-storage connectors/source/zoom
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sherifnada @maxi297 @octavia-squidington-iv