qa-engine: implement early enrichments and validations on QA report #21776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alafanechere
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
alafanechere
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
alafanechere
force-pushed
the
augustin/qa-engine/spot-not-on-cloud
branch
from
2b59dd4 to
9697f07
Compare
alafanechere
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
alafanechere
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
Airbyte Code Coverage
|
alafanechere
force-pushed
the
augustin/qa-engine/spot-not-on-cloud
branch
from
9697f07 to
366663b
Compare
alafanechere
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
alafanechere
force-pushed
the
augustin/qa-engine/spot-not-on-cloud
branch
from
de933c0 to
76fda5f
Compare
alafanechere
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
alafanechere
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
alafanechere
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
alafanechere
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
alafanechere
force-pushed
the
augustin/qa-engine/spot-not-on-cloud
branch
2 times, most recently
from
f320e64 to
3a160f8
Compare
alafanechere
force-pushed
the
augustin/qa-engine/spot-not-on-cloud
branch
from
3a160f8 to
ff33a0a
Compare
alafanechere
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
alafanechere
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
This was referenced Jan 25, 2023
evantahler
approved these changes
Jan 25, 2023
Comment on lines
+9
to
+13
| INAPPROPRIATE_FOR_CLOUD_USE_CONNECTORS = [ | ||
| "8be1cf83-fde1-477f-a4ad-318d23c9f3c6", # Local CSV | ||
| "a625d593-bba5-4a1c-a53d-2d246268a816", # Local JSON | ||
| "b76be0a6-27dc-4560-95f6-2623da0bd7b6" # Local SQL Lite | ||
| ] |
There was a problem hiding this comment.
👍
Perhaps one day we store this information in the metadata
| from pydantic import BaseModel | ||
|
|
||
| class ConnectorTypeEnum(str, Enum): | ||
| source = "source" | ||
| destination = "destination" | ||
|
|
||
| class ReleaseStageEnum(str, Enum): | ||
| unknown = "unknown" |
There was a problem hiding this comment.
What unknown connectors did you find?
There was a problem hiding this comment.
- source-freshcaller
- source-genesys
- source-rss
- destination-e2e-testing
Comment on lines
+48
to
+52
| # TODO YET TO IMPLEMENT VALIDATIONS | ||
| qa_report["latest_build_is_successful"] = False # TODO, tracked in https://github.com/airbytehq/airbyte/issues/21720 | ||
| qa_report["number_of_connections"] = 0 # TODO, tracked in https://github.com/airbytehq/airbyte/issues/21721 | ||
| qa_report["number_of_users"] = 0 # TODO, tracked in https://github.com/airbytehq/airbyte/issues/21721 | ||
| qa_report["sync_success_rate"] = .0 # TODO, tracked in https://github.com/airbytehq/airbyte/issues/21721 |
There was a problem hiding this comment.
👍 good placeholders for future work
This was referenced Jan 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Closes #21719
Closes #21724
Closes #21722
Implement generation of QA report with actual data from the OSS and Cloud combined catalogs.
Generate a report with the expected columns and implement early checks:
documentation_is_availableis_appropriate_for_cloud_useHow
Create an enriched intermediate catalog:
Create the QA report from the enriched catalog:
documentation_is_available: check if GET documentation url returns200.is_appropriate_for_cloud_use: check if the connector definition id is part of theINAPPROPRIATE_FOR_CLOUD_USElist.