Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add WellKnownTypes to the Orchestrator #21897

Merged
merged 4 commits into from
Jan 26, 2023
Merged

Add WellKnownTypes to the Orchestrator #21897

merged 4 commits into from
Jan 26, 2023

Conversation

gosusnp
Copy link
Contributor

@gosusnp gosusnp commented Jan 26, 2023

What

WellKnownTypes.json is only available in the workers, we need it in the orchestrator as well for kube based environments.

How

  • Add missing dependency in the worker build
  • Generate WellKnownTypes.json for the orchestrator

@gosusnp gosusnp requested a review from a team as a code owner January 26, 2023 01:25
@gosusnp gosusnp requested a review from edgao January 26, 2023 01:25
@octavia-squidington-iv octavia-squidington-iv added area/platform issues related to the platform area/worker Related to worker labels Jan 26, 2023
@gosusnp gosusnp temporarily deployed to more-secrets January 26, 2023 01:27 — with GitHub Actions Inactive
@gosusnp gosusnp temporarily deployed to more-secrets January 26, 2023 01:27 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Jan 26, 2023 •
edited
Loading

Airbyte Code Coverage

There is no coverage information present for the Files changed

Total Project Coverage 23.99% ❌

edgao
edgao approved these changes Jan 26, 2023
View reviewed changes
Copy link
Contributor

@edgao edgao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple nitpicky comments. lgtm though

airbyte-container-orchestrator/build.gradle Show resolved Hide resolved
airbyte-workers/build.gradle Show resolved Hide resolved
@gosusnp gosusnp temporarily deployed to more-secrets January 26, 2023 17:18 — with GitHub Actions Inactive
@gosusnp gosusnp temporarily deployed to more-secrets January 26, 2023 17:18 — with GitHub Actions Inactive
@gosusnp gosusnp temporarily deployed to more-secrets January 26, 2023 17:35 — with GitHub Actions Inactive
@gosusnp gosusnp temporarily deployed to more-secrets January 26, 2023 17:35 — with GitHub Actions Inactive
@gosusnp gosusnp enabled auto-merge (squash) January 26, 2023 17:37
@gosusnp gosusnp temporarily deployed to more-secrets January 26, 2023 18:19 — with GitHub Actions Inactive
@gosusnp gosusnp temporarily deployed to more-secrets January 26, 2023 18:19 — with GitHub Actions Inactive
@gosusnp gosusnp temporarily deployed to more-secrets January 26, 2023 18:48 — with GitHub Actions Inactive
@gosusnp gosusnp temporarily deployed to more-secrets January 26, 2023 18:48 — with GitHub Actions Inactive
@gosusnp gosusnp merged commit fa24ad6 into master Jan 26, 2023
@gosusnp gosusnp deleted the gosusnp/add-wellknowntypes-to-orchestrator branch January 26, 2023 19:19
This was referenced Jan 27, 2023
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edgao edgao edgao approved these changes

Assignees
No one assigned
Labels
area/platform issues related to the platform area/worker Related to worker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gosusnp @edgao @octavia-squidington-iv