pass connection_id to replication activity apm tags #21949
Conversation
octavia-squidington-iv
added
area/platform
| .withDestinationResourceRequirements(config.getDestinationResourceRequirements()); | ||
| .withDestinationResourceRequirements(config.getDestinationResourceRequirements()) | ||
| .withConnectionId(connectionId) | ||
| .withWorkspaceId(config.getWorkspaceId()); |
There was a problem hiding this comment.
I noticed workspace_id wasn't passed in here. But is passed in other places where we build this struct. @mfsiega-airbyte was that intentional?
There was a problem hiding this comment.
Indeed not intentional - but same question as Pedro.
| @@ -400,7 +400,9 @@ public TemporalResponse<StandardSyncOutput> submitSync(final long jobId, final i | |||
| .withState(config.getState()) | |||
There was a problem hiding this comment.
I noticed source_id and destination_id wasn't passed in here. But is passed in other places where we build this struct. @pedroslopez was that intentional?
There was a problem hiding this comment.
Not intentional. I didn't know submitSync was a thing when working on the original PR that introduced them.
I've actually been recently trying to understand where this submitSync method comes into play... when does this get executed? From what I've seen we're always using the inputs as generated by the GenerateInputActivity in actual sync jobs.
There was a problem hiding this comment.
tbh, i've lost track of it as well. @benmoriceau is this something you understand well?
Airbyte Code Coverage
|
cgardens
deleted the
cgardens/pass-connection-id-to-replicate-activity
branch
What
How
connection_idas one of the keys that gets passed in viaStandardSyncInput.