Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎉 Google Analytics: support incremental sync #2302

Merged
merged 9 commits into from
Mar 11, 2021
Merged

🎉 Google Analytics: support incremental sync #2302

merged 9 commits into from
Mar 11, 2021

Conversation

vitaliizazmic
Copy link
Contributor

What

Setting installing Google Analytics Tap from incremental_mode branch of vitaliizazmic fork for testing new incremental changes.

Pre-merge Checklist

  • Run integration tests
  • Publish Docker images

@vitaliizazmic
Copy link
Contributor Author

vitaliizazmic commented Mar 4, 2021 •
edited by github-actions bot
Loading

/test connector=source-googleanalytics-singer

🕑 source-googleanalytics-singer https://github.com/airbytehq/airbyte/actions/runs/620841981
❌ source-googleanalytics-singer https://github.com/airbytehq/airbyte/actions/runs/620841981

@sherifnada
Copy link
Contributor

sherifnada commented Mar 4, 2021 •
edited by github-actions bot
Loading

/test connector=source-googleanalytics-singer

🕑 source-googleanalytics-singer https://github.com/airbytehq/airbyte/actions/runs/621714114
❌ source-googleanalytics-singer https://github.com/airbytehq/airbyte/actions/runs/621714114

@sherifnada
Copy link
Contributor

sherifnada commented Mar 5, 2021 •
edited by github-actions bot
Loading

/test connector=source-googleanalytics-singer

🕑 source-googleanalytics-singer https://github.com/airbytehq/airbyte/actions/runs/624819730
❌ source-googleanalytics-singer https://github.com/airbytehq/airbyte/actions/runs/624819730

@sherifnada
Copy link
Contributor

@vitaliizazmic the failure was being caused by a bug in standard tests -- please proceed with publishing the connector

@sherifnada
Copy link
Contributor

sherifnada commented Mar 8, 2021 •
edited by github-actions bot
Loading

/test connector=source-googleanalytics-singer

🕑 source-googleanalytics-singer https://github.com/airbytehq/airbyte/actions/runs/633949189
❌ source-googleanalytics-singer https://github.com/airbytehq/airbyte/actions/runs/633949189

@vitaliizazmic
Copy link
Contributor Author

vitaliizazmic commented Mar 9, 2021 •
edited by github-actions bot
Loading

/test connector=source-googleanalytics-singer

🕑 source-googleanalytics-singer https://github.com/airbytehq/airbyte/actions/runs/636992878
❌ source-googleanalytics-singer https://github.com/airbytehq/airbyte/actions/runs/636992878

@vitaliizazmic
Copy link
Contributor Author

vitaliizazmic commented Mar 9, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-googleanalytics-singer

🕑 connectors/source-googleanalytics-singer https://github.com/airbytehq/airbyte/actions/runs/637138176
❌ connectors/source-googleanalytics-singer https://github.com/airbytehq/airbyte/actions/runs/637138176

@vitaliizazmic
Copy link
Contributor Author

vitaliizazmic commented Mar 10, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-googleanalytics-singer

🕑 connectors/source-googleanalytics-singer https://github.com/airbytehq/airbyte/actions/runs/639474441
❌ connectors/source-googleanalytics-singer https://github.com/airbytehq/airbyte/actions/runs/639474441

@vitaliizazmic
Copy link
Contributor Author

vitaliizazmic commented Mar 10, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-googleanalytics-singer

🕑 connectors/source-googleanalytics-singer https://github.com/airbytehq/airbyte/actions/runs/639800398
✅ connectors/source-googleanalytics-singer https://github.com/airbytehq/airbyte/actions/runs/639800398

sherifnada
sherifnada suggested changes Mar 10, 2021
View reviewed changes
Copy link
Contributor

@sherifnada sherifnada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this was tested correctly -- the configured catalogs have not changed, and the catalog output by the connector has not changed I believe? Shouldn't those have changed?

airbyte-integrations/connectors/source-googleanalytics-singer/setup.py Outdated Show resolved Hide resolved
@vitaliizazmic
Copy link
Contributor Author

I don't think this was tested correctly -- the configured catalogs have not changed, and the catalog output by the connector has not changed I believe? Shouldn't those have changed?

I will check it

@sherifnada
Copy link
Contributor

sherifnada commented Mar 11, 2021 •
edited by github-actions bot
Loading

/test connector=source-google-analytics

🕑 source-google-analytics https://github.com/airbytehq/airbyte/actions/runs/643566728
❌ source-google-analytics https://github.com/airbytehq/airbyte/actions/runs/643566728

@sherifnada
Copy link
Contributor

sherifnada commented Mar 11, 2021 •
edited by github-actions bot
Loading

/test connector=source-googleanalytics-singer

🕑 source-googleanalytics-singer https://github.com/airbytehq/airbyte/actions/runs/643567447
✅ source-googleanalytics-singer https://github.com/airbytehq/airbyte/actions/runs/643567447

@vitaliizazmic
Copy link
Contributor Author

vitaliizazmic commented Mar 11, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-googleanalytics-singer

🕑 connectors/source-googleanalytics-singer https://github.com/airbytehq/airbyte/actions/runs/644125616
✅ connectors/source-googleanalytics-singer https://github.com/airbytehq/airbyte/actions/runs/644125616

@sherifnada sherifnada changed the title Google Analytics #2106 - incremental mode 🎉 Google Analytics: support incremental sync Mar 11, 2021
vitaliizazmic
vitaliizazmic commented Mar 11, 2021
View reviewed changes
Copy link
Contributor Author

@vitaliizazmic vitaliizazmic left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tap fork changed

@vitaliizazmic vitaliizazmic merged commit 7743e39 into master Mar 11, 2021
@vitaliizazmic vitaliizazmic deleted the vitalii/2106_ga_incrementall_sync branch March 11, 2021 22:22
@sherifnada sherifnada mentioned this pull request Mar 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sherifnada sherifnada sherifnada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vitaliizazmic @sherifnada