Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source Iterable: add retry for 500 - Generic Error, increase reduce slice max attempts #23821

Merged

Conversation

bazarnov
Copy link
Collaborator

@bazarnov bazarnov commented Mar 7, 2023

What

Resolving:

How

  • increased the CHUNKED_ENCODING_ERROR_RETRIES from 3 to 6 (2 times bigger) to give 3 more attempts to retry.
  • added should_retry == True logic for 500 - Generic Error

🚨 User Impact 🚨

No impact is expected, due to small code addings.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

@bazarnov
Copy link
Collaborator Author

bazarnov commented Mar 7, 2023

/test connector=connectors/source-iterable

FAILED: due to GitHub RateLimits : (

@bazarnov
Copy link
Collaborator Author

bazarnov commented Mar 7, 2023

/test connector=connectors/source-iterable

🕑 connectors/source-iterable https://github.com/airbytehq/airbyte/actions/runs/4359284507
✅ connectors/source-iterable https://github.com/airbytehq/airbyte/actions/runs/4359284507
Python tests coverage:

Name                                  Stmts   Miss  Cover
---------------------------------------------------------
source_iterable/utils.py                  5      0   100%
source_iterable/__init__.py               2      0   100%
source_iterable/source.py                34      1    97%
source_iterable/slice_generators.py      71      5    93%
source_iterable/streams.py              361     41    89%
---------------------------------------------------------
TOTAL                                   473     47    90%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:509: The previous and actual discovered catalogs are identical.
================== 35 passed, 2 skipped in 1334.32s (0:22:14) ==================

Copy link
Collaborator

@lazebnyi lazebnyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bazarnov
Copy link
Collaborator Author

bazarnov commented Mar 9, 2023

/test connector=connectors/source-iterable

🕑 connectors/source-iterable https://github.com/airbytehq/airbyte/actions/runs/4375091050
✅ connectors/source-iterable https://github.com/airbytehq/airbyte/actions/runs/4375091050
Python tests coverage:

Name                                  Stmts   Miss  Cover
---------------------------------------------------------
source_iterable/utils.py                  5      0   100%
source_iterable/__init__.py               2      0   100%
source_iterable/slice_generators.py      71      5    93%
source_iterable/streams.py              357     42    88%
source_iterable/source.py                34      4    88%
---------------------------------------------------------
TOTAL                                   469     51    89%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:509: The previous and actual discovered catalogs are identical.
================== 35 passed, 2 skipped in 1324.49s (0:22:04) ==================

@bazarnov
Copy link
Collaborator Author

bazarnov commented Mar 9, 2023

/publish connector=connectors/source-iterable

🕑 Publishing the following connectors:
connectors/source-iterable
https://github.com/airbytehq/airbyte/actions/runs/4375497200


Connector Did it publish? Were definitions generated?
connectors/source-iterable

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@bazarnov bazarnov merged commit 9927b0c into master Mar 9, 2023
@bazarnov bazarnov deleted the baz/source-iterable-fix-retry-slice-reduce-max-attempts branch March 9, 2023 15:52
danielduckworth pushed a commit to danielduckworth/airbyte that referenced this pull request Mar 13, 2023
adriennevermorel pushed a commit to adriennevermorel/airbyte that referenced this pull request Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/iterable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source Iterable hits rate limit on initial sync, even after greatly reducing the total count & size of streams
4 participants