-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Source Iterable: add retry for 500 - Generic Error, increase reduce slice max attempts
#23821
🐛 Source Iterable: add retry for 500 - Generic Error, increase reduce slice max attempts
#23821
Conversation
/test connector=connectors/source-iterable FAILED: due to GitHub RateLimits : ( |
/test connector=connectors/source-iterable
Build PassedTest summary info:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…-fix-retry-slice-reduce-max-attempts
…-fix-retry-slice-reduce-max-attempts
/test connector=connectors/source-iterable
Build PassedTest summary info:
|
/publish connector=connectors/source-iterable
if you have connectors that successfully published but failed definition generation, follow step 4 here |
…e slice max attempts` (airbytehq#23821)
…e slice max attempts` (airbytehq#23821)
What
Resolving:
How
CHUNKED_ENCODING_ERROR_RETRIES
from 3 to 6 (2 times bigger) to give 3 more attempts to retry.should_retry == True
logic for 500 - Generic Error🚨 User Impact 🚨
No impact is expected, due to small code addings.
Pre-merge Checklist
Expand the relevant checklist and delete the others.
Updating a connector
Community member or Airbyter
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described here