Add docs on normalization naming rules #2576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davinchia
approved these changes
Mar 23, 2021
| - `cars` for the original parent table | ||
| - `cars_da3_cars` for the expanded nested columns following this naming scheme in 3 parts: `<Parent prefix>_<Hash>_<nested column name>` | ||
|
|
||
| 1. Parent prefix: The entire json path string with '_' characters used as delimiters to reach the parent table name |
There was a problem hiding this comment.
Should json path = json path to the nested column to be clearer?
|
|
||
| Other modern data warehouses have much higher limits in terms of authorized name lengths so this should not be affecting us that often. | ||
| However, in the rare cases where these limits should be reached, Basic Normalization will have to resort to fallback rules as follows: | ||
| 1. No Truncate if under destination's character limits |
There was a problem hiding this comment.
Should we leave this out since it describes a case where it's under the limit?
| | Description | Example 1 | Example 2 | | ||
| | :--- | :--- | :--- | | ||
| | Original Stream Name | `companies` | `deals` | | ||
| | Json path to the nested column | `companies/property_engagements_last_meeting_booked_campaign` | `deals/properties/engagements_last_meeting_booked_medium` | |
There was a problem hiding this comment.
Some suggestions:
*might be nice to show the truncated bits
- I don't fully understand the prefix truncation, maybe have an example?
There was a problem hiding this comment.
The examples do include the prefix truncation
I added some colors in the bigquery results (non-truncated) to highlight the differences from the postgres ones (truncated)
Co-authored-by: Davin Chia <davinchia@gmail.com>
davydov-d
added a commit
that referenced
this pull request
Nov 8, 2022
davydov-d
added a commit
that referenced
this pull request
Nov 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Describe how normalization choose names for nested tables