Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java DB Source connector licenses to Elv2 #27737

Merged
merged 5 commits into from
Jun 29, 2023
Merged

Conversation

evantahler
Copy link
Contributor

See #27724

@evantahler evantahler marked this pull request as ready for review June 27, 2023 00:19
@evantahler evantahler requested a review from a team as a code owner June 27, 2023 00:19
@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Jun 27, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 27, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan and you've followed all steps in the Breaking Changes Checklist
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • The connector tests are passing in CI
  • You've updated the connector's metadata.yaml file (new!)
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@github-actions
Copy link
Contributor

Coverage report for source-postgres

There is no coverage information present for the Files changed

Total Project Coverage 67.57% 🍏

@octavia-squidington-iii
Copy link
Collaborator

source-snowflake test report (commit 28e9a01e9b) - ❌

⏲️ Total pipeline duration: 707 seconds

Step Result
Validate airbyte-integrations/connectors/source-snowflake/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Build connector tar
Build source-snowflake docker image for platform linux/x86_64
Unit tests
Integration tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-snowflake test

@octavia-squidington-iii
Copy link
Collaborator

source-bigquery test report (commit 28e9a01e9b) - ✅

⏲️ Total pipeline duration: 1087 seconds

Step Result
Validate airbyte-integrations/connectors/source-bigquery/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Build connector tar
Build source-bigquery docker image for platform linux/x86_64
Unit tests
Integration tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-bigquery test

@evantahler
Copy link
Contributor Author

Merging in master... I would have expected a lot more tests to have run...

@evantahler
Copy link
Contributor Author

@alafanechere I added you as a reviewer because I'm not really sure what to do since the connector tests aren't running

@octavia-squidington-iii
Copy link
Collaborator

source-mysql test report (commit 445f3b7838) - ❌

⏲️ Total pipeline duration: 1898 seconds

Step Result
Validate airbyte-integrations/connectors/source-mysql/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Build connector tar
Build source-mysql docker image for platform linux/x86_64
Unit tests
Integration tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-mysql test

@octavia-squidington-iii
Copy link
Collaborator

source-postgres-strict-encrypt test report (commit 445f3b7838) - ✅

⏲️ Total pipeline duration: 417 seconds

Step Result

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-postgres-strict-encrypt test

@octavia-squidington-iii
Copy link
Collaborator

source-mssql test report (commit 445f3b7838) - ❌

⏲️ Total pipeline duration: 2177 seconds

Step Result
Validate airbyte-integrations/connectors/source-mssql/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Build connector tar
Build source-mssql docker image for platform linux/x86_64
Unit tests
Integration tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-mssql test

@octavia-squidington-iii
Copy link
Collaborator

source-mysql-strict-encrypt test report (commit 445f3b7838) - ❌

⏲️ Total pipeline duration: 1778 seconds

Step Result
Validate airbyte-integrations/connectors/source-mysql-strict-encrypt/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Build connector tar
Build source-mysql-strict-encrypt docker image for platform linux/x86_64
Unit tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-mysql-strict-encrypt test

@alafanechere
Copy link
Contributor

alafanechere commented Jun 28, 2023

@evantahler the test did run and started on 28e9a01e9b, but the source-mssql-strict-encrypt unit tests have a problem and never finish, the workflow was killed after 24H.
When you merged in master with 445f3b7838 the tests restarted, other connector were tested before mssql but the workllow is now at mssql again and that will probably block the rest of the connectors test.

When I run: ./gradlew :airbyte-integrations:connectors:source-mssql-strict-encrypt:test locally the test are indeed stuck at setup... This can be a networking issue with connection to testcontainer, the same kind of problem I fixed for Postgres and other connectors, the helpers to resolve the testcontainer ip/port might be custom on this connector. I will run legacy-test to check if its a regression of the new pipelines.

To prevent this situation from happening I could declare a fixed timeout to java connectors tests. I did not do it so far globally on tests because we have python connectors that are very long to test due to rate limits (source-mixpanel test can run for ~3hours...)

@alafanechere
Copy link
Contributor

alafanechere commented Jun 28, 2023

/legacy-test connector=connectors/source-mssql-strict-encrypt

🕑 connectors/source-mssql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/5399556614
✅ connectors/source-mssql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/5399556614
No Python unittests run

Build Passed

Test summary info:

All Passed

@alafanechere
Copy link
Contributor

@evantahler I think I'm understanding the problem with source-mssql-strict-encrypt.
When running ./gradlew :airbyte-integrations:connectors:source-mssql-strict-encrypt:test the gradle task idles forever, I don't know exactly why. We run the test gradle task to run unit tests.
/test is running a different gradle task: integrationTest.

I originally split unit and integration test for Java connectors by running test and integrationTestJava. I believe this assumption is not correct for all connectors...

I'm trying switching to integrationTest only in #27794

@octavia-squidington-iii
Copy link
Collaborator

source-oracle test report (commit 2ad90796c9) - ❌

⏲️ Total pipeline duration: 287 seconds

Step Result
Validate airbyte-integrations/connectors/source-oracle/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Build connector tar
Build source-oracle docker image for platform linux/x86_64
./gradlew :airbyte-integrations:connectors:source-oracle:integrationTest
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-oracle test

@octavia-squidington-iii
Copy link
Collaborator

source-postgres test report (commit 2ad90796c9) - ✅

⏲️ Total pipeline duration: 715 seconds

Step Result
Validate airbyte-integrations/connectors/source-postgres/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Build connector tar
Build source-postgres docker image for platform linux/x86_64
./gradlew :airbyte-integrations:connectors:source-postgres:integrationTest
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-postgres test

@octavia-squidington-iii
Copy link
Collaborator

source-bigquery test report (commit 2ad90796c9) - ✅

⏲️ Total pipeline duration: 772 seconds

Step Result
Validate airbyte-integrations/connectors/source-bigquery/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Build connector tar
Build source-bigquery docker image for platform linux/x86_64
./gradlew :airbyte-integrations:connectors:source-bigquery:integrationTest
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-bigquery test

@octavia-squidington-iii
Copy link
Collaborator

source-mssql-strict-encrypt test report (commit 2ad90796c9) - ❌

⏲️ Total pipeline duration: 931 seconds

Step Result
Validate airbyte-integrations/connectors/source-mssql-strict-encrypt/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Build connector tar
Build source-mssql-strict-encrypt docker image for platform linux/x86_64
./gradlew :airbyte-integrations:connectors:source-mssql-strict-encrypt:integrationTest
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-mssql-strict-encrypt test

@octavia-squidington-iii
Copy link
Collaborator

source-snowflake test report (commit 2ad90796c9) - ❌

⏲️ Total pipeline duration: 593 seconds

Step Result
Validate airbyte-integrations/connectors/source-snowflake/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Build connector tar
Build source-snowflake docker image for platform linux/x86_64
./gradlew :airbyte-integrations:connectors:source-snowflake:integrationTest
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-snowflake test

@octavia-squidington-iii
Copy link
Collaborator

source-oracle-strict-encrypt test report (commit 2ad90796c9) - ❌

⏲️ Total pipeline duration: 1076 seconds

Step Result
Validate airbyte-integrations/connectors/source-oracle-strict-encrypt/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Build connector tar
Build source-oracle-strict-encrypt docker image for platform linux/x86_64
./gradlew :airbyte-integrations:connectors:source-oracle-strict-encrypt:integrationTest
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-oracle-strict-encrypt test

@octavia-squidington-iii
Copy link
Collaborator

source-redshift test report (commit 2ad90796c9) - ❌

⏲️ Total pipeline duration: 631 seconds

Step Result
Validate airbyte-integrations/connectors/source-redshift/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Build connector tar
Build source-redshift docker image for platform linux/x86_64
./gradlew :airbyte-integrations:connectors:source-redshift:integrationTest
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-redshift test

@octavia-squidington-iii
Copy link
Collaborator

source-postgres-strict-encrypt test report (commit 2ad90796c9) - ❌

⏲️ Total pipeline duration: 359 seconds

Step Result
Validate airbyte-integrations/connectors/source-postgres-strict-encrypt/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Build connector tar
Build source-postgres-strict-encrypt docker image for platform linux/x86_64
./gradlew :airbyte-integrations:connectors:source-postgres-strict-encrypt:integrationTest
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-postgres-strict-encrypt test

@octavia-squidington-iii
Copy link
Collaborator

source-mssql test report (commit 2ad90796c9) - ❌

⏲️ Total pipeline duration: 1150 seconds

Step Result
Validate airbyte-integrations/connectors/source-mssql/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Build connector tar
Build source-mssql docker image for platform linux/x86_64
./gradlew :airbyte-integrations:connectors:source-mssql:integrationTest
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-mssql test

@octavia-squidington-iii
Copy link
Collaborator

source-mongodb-v2 test report (commit 2ad90796c9) - ❌

⏲️ Total pipeline duration: 652 seconds

Step Result
Validate airbyte-integrations/connectors/source-mongodb-v2/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Build connector tar
Build source-mongodb-v2 docker image for platform linux/x86_64
./gradlew :airbyte-integrations:connectors:source-mongodb-v2:integrationTest
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-mongodb-v2 test

@octavia-squidington-iii
Copy link
Collaborator

source-mysql-strict-encrypt test report (commit 2ad90796c9) - ❌

⏲️ Total pipeline duration: 778 seconds

Step Result
Validate airbyte-integrations/connectors/source-mysql-strict-encrypt/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Build connector tar
Build source-mysql-strict-encrypt docker image for platform linux/x86_64
./gradlew :airbyte-integrations:connectors:source-mysql-strict-encrypt:integrationTest
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-mysql-strict-encrypt test

@octavia-squidington-iii
Copy link
Collaborator

source-mysql test report (commit 2ad90796c9) - ❌

⏲️ Total pipeline duration: 982 seconds

Step Result
Validate airbyte-integrations/connectors/source-mysql/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Build connector tar
Build source-mysql docker image for platform linux/x86_64
./gradlew :airbyte-integrations:connectors:source-mysql:integrationTest
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-mysql test

@octavia-squidington-iii
Copy link
Collaborator

source-mongodb-strict-encrypt test report (commit 2ad90796c9) - ❌

⏲️ Total pipeline duration: 269 seconds

Step Result
Validate airbyte-integrations/connectors/source-mongodb-strict-encrypt/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Build connector tar
Build source-mongodb-strict-encrypt docker image for platform linux/x86_64
./gradlew :airbyte-integrations:connectors:source-mongodb-strict-encrypt:integrationTest

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-mongodb-strict-encrypt test

@evantahler
Copy link
Contributor Author

evantahler commented Jun 29, 2023

I think this is safe to merge!

  • Some of the connectors passed all the tests
  • There are no failing metadata problems
  • There's one QA check failure (source-mongodb-strict-encrypt), and I think this is real, but it is the same way on master (source-mongodb-strict-encrypt maps to source-mongodb-v2 for some reason, so the lookup for icons etc doesn't work
  • ERROR:root:The following GA connectors must enable high test strictness level: [source-postgres-strict-encrypt, source-postgres] is expected

@evantahler evantahler merged commit 9ce3cc6 into master Jun 29, 2023
@evantahler evantahler deleted the evan/elv2-db-sources branch June 29, 2023 01:52
@nataliekwong
Copy link
Contributor

Hey @evantahler , a community member raised that we don't have a license file in the file or same directory, so it isn't clear that these are now under Elv2. Do you know who could help to add those? (Not sure between Connector Ops/DB Sources?)

#31503

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment