Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Destinations V2: change singleton log message level from warn to debug #27887

Merged
merged 1 commit into from
Jun 30, 2023

Conversation

cynthiaxyin
Copy link
Contributor

Retrieving a value from the destination config singleton is done in a fair amount of places so this was polluting the sync logs. Lower the log level from warn to debug.

Verified this doesn't show up anymore in a non-1s1t sync run locally.

@cynthiaxyin cynthiaxyin requested a review from a team as a code owner June 30, 2023 20:18
@cynthiaxyin cynthiaxyin requested a review from a team June 30, 2023 20:18
Copy link
Contributor

@evantahler evantahler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤫

@cynthiaxyin cynthiaxyin merged commit 98a0dad into master Jun 30, 2023
@cynthiaxyin cynthiaxyin deleted the cynthia/dest-v2-log-messages branch June 30, 2023 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants