Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Destination bigquery denormalized: pin to 1.4.1 #27890

Merged
merged 1 commit into from
Jun 30, 2023

Conversation

edgao
Copy link
Contributor

@edgao edgao commented Jun 30, 2023

@edgao edgao requested a review from a team as a code owner June 30, 2023 21:11
@edgao edgao changed the title Destination bigquery denormalized: pint to 1.4.1 Destination bigquery denormalized: pin to 1.4.1 Jun 30, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 30, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan and you've followed all steps in the Breaking Changes Checklist
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • The connector tests are passing in CI
  • You've updated the connector's metadata.yaml file (new!)
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@edgao edgao enabled auto-merge (squash) June 30, 2023 21:20
@edgao
Copy link
Contributor Author

edgao commented Jun 30, 2023

/approve-and-merge reason="pure metadata change, skipping ci"

@octavia-approvington
Copy link
Contributor

All in!!
all in baby

@octavia-approvington octavia-approvington merged commit 7e7c6f2 into master Jun 30, 2023
@octavia-approvington octavia-approvington deleted the edgao-patch-1 branch June 30, 2023 21:21
@octavia-squidington-iii
Copy link
Collaborator

destination-bigquery-denormalized test report (commit 194a4a2589) - ✅

⏲️ Total pipeline duration: 19mn00s

Step Result
Validate airbyte-integrations/connectors/destination-bigquery-denormalized/metadata.yaml
Connector version semver check
QA checks
Build connector tar
Build destination-bigquery-denormalized docker image for platform linux/x86_64
./gradlew :airbyte-integrations:connectors:destination-bigquery-denormalized:integrationTest

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-bigquery-denormalized test

mauricioalarcon pushed a commit to betterup/airbyte that referenced this pull request Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants