Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Destination Bigquery: 1s1t: handle raw name collisions #28366

Merged
merged 4 commits into from
Jul 17, 2023
Merged

Destination Bigquery: 1s1t: handle raw name collisions #28366

merged 4 commits into from
Jul 17, 2023

Conversation

edgao
Copy link
Contributor

@edgao edgao commented Jul 17, 2023

closes #27798

Slightly different logic after discussing with @jbfbell . Instead of just using a double-underscore, we're now generating a name based on each individual stream. This is to make the raw tablename unambiguous.

best to review commit-by-commit:

  • 69cd763 - move inner classes to their own files
  • 2d3b86a - runtime code change
  • 8154cb6 - update tests with new tablenames

@edgao edgao requested a review from a team as a code owner July 17, 2023 18:06
@github-actions
Copy link
Contributor

github-actions bot commented Jul 17, 2023 •
edited by edgao
Loading

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan and you've followed all steps in the Breaking Changes Checklist
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • The connector tests are passing in CI
  • You've updated the connector's metadata.yaml file (new!)
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@edgao edgao changed the title 1s1t: handle raw name collisions Destination Bigquery: 1s1t: handle raw name collisions Jul 17, 2023
@octavia-squidington-iii
Copy link
Collaborator

destination-bigquery test report (commit 8154cb60b1) - ❌

⏲️ Total pipeline duration: 36mn22s

Step Result
Validate airbyte-integrations/connectors/destination-bigquery/metadata.yaml ✅
Connector version semver check ❌
QA checks ✅
Build connector tar ✅
Build destination-bigquery docker image for platform linux/x86_64 ✅
Build airbyte/normalization:dev ✅
./gradlew :airbyte-integrations:connectors:destination-bigquery:integrationTest ❌

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-bigquery test

@octavia-squidington-iii
Copy link
Collaborator

destination-bigquery-denormalized test report (commit 8154cb60b1) - ❌

⏲️ Total pipeline duration: 22mn05s

Step Result
Validate airbyte-integrations/connectors/destination-bigquery-denormalized/metadata.yaml ✅
Connector version semver check ❌
QA checks ✅
Build connector tar ✅
Build destination-bigquery-denormalized docker image for platform linux/x86_64 ✅
./gradlew :airbyte-integrations:connectors:destination-bigquery-denormalized:integrationTest ✅

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-bigquery-denormalized test

@octavia-squidington-iii
Copy link
Collaborator

destination-bigquery test report (commit bcc7582297) - ❌

⏲️ Total pipeline duration: 36mn26s

Step Result
Validate airbyte-integrations/connectors/destination-bigquery/metadata.yaml ✅
Connector version semver check ❌
QA checks ✅
Build connector tar ✅
Build destination-bigquery docker image for platform linux/x86_64 ✅
Build airbyte/normalization:dev ✅
./gradlew :airbyte-integrations:connectors:destination-bigquery:integrationTest ✅

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-bigquery test

@octavia-squidington-iii
Copy link
Collaborator

destination-bigquery-denormalized test report (commit bcc7582297) - ❌

⏲️ Total pipeline duration: 22mn08s

Step Result
Validate airbyte-integrations/connectors/destination-bigquery-denormalized/metadata.yaml ✅
Connector version semver check ❌
QA checks ✅
Build connector tar ✅
Build destination-bigquery-denormalized docker image for platform linux/x86_64 ✅
./gradlew :airbyte-integrations:connectors:destination-bigquery-denormalized:integrationTest ✅

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-bigquery-denormalized test

@edgao
Copy link
Contributor Author

edgao commented Jul 17, 2023

/approve-and-merge reason="tests passing; continuing to skip publish for now"

@octavia-approvington
Copy link
Contributor

Approve this
imagine the commander saying yes

@octavia-approvington octavia-approvington merged commit 4f64c2a into master Jul 17, 2023
12 of 13 checks passed
@octavia-approvington octavia-approvington deleted the edgao/1s1t/raw_collisions branch July 17, 2023 20:39
@edgao edgao mentioned this pull request Jul 19, 2023
Merged
efimmatytsin pushed a commit to scentbird/airbyte that referenced this pull request Jul 27, 2023
@edgao @efimmatytsin
Destination Bigquery: 1s1t: handle raw name collisions (airbytehq#28366)
ea41ff9 
* move records to separate files

* better raw table names

* update tests

* manual format b/c CI bugged out
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbfbell jbfbell jbfbell approved these changes

@octavia-approvington octavia-approvington octavia-approvington approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues checklist-action-run connectors/destination/bigquery
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1s1t CatalogParser should handle raw table name collisions
4 participants
@edgao @octavia-squidington-iii @octavia-approvington @jbfbell