-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Destinations V2: clean up AirbyteType code #28430
Conversation
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
8e8fbd4
to
a61cc28
Compare
if (!foundExcludedTypes) { | ||
return protocolType; | ||
// Picks which type in a Union takes precedence | ||
public static AirbyteType chooseUnionType(final Union u) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
much simpler and easier to read than before :)
ae1ecc3
to
f166ec5
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
1934202
to
759032d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
had a few comments but nothing blocking. I'd weakly like to completely kill the AirbyteTypeUtils class and have those two methods both live inside AirbyteType.java, but only very weakly.
...src/main/java/io/airbyte/integrations/base/destination/typing_deduping/AirbyteTypeUtils.java
Outdated
Show resolved
Hide resolved
.../src/test/java/io/airbyte/integrations/base/destination/typing_deduping/AirbyteTypeTest.java
Outdated
Show resolved
Hide resolved
...src/main/java/io/airbyte/integrations/base/destination/typing_deduping/AirbyteTypeUtils.java
Outdated
Show resolved
Hide resolved
...src/main/java/io/airbyte/integrations/base/destination/typing_deduping/AirbyteTypeUtils.java
Outdated
Show resolved
Hide resolved
...ping/src/main/java/io/airbyte/integrations/base/destination/typing_deduping/AirbyteType.java
Show resolved
Hide resolved
5b137da
to
45722bb
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
6e82aba
to
ae42899
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
destination-bigquery test report (commit
|
Step | Result |
---|---|
Validate airbyte-integrations/connectors/destination-bigquery/metadata.yaml | ✅ |
Connector version semver check | ✅ |
QA checks | ✅ |
Build connector tar | ✅ |
Build destination-bigquery docker image for platform linux/x86_64 | ✅ |
Build airbyte/normalization:dev | ✅ |
./gradlew :airbyte-integrations:connectors:destination-bigquery:integrationTest | ✅ |
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=destination-bigquery test
destination-bigquery-denormalized test report (commit
|
Step | Result |
---|---|
Validate airbyte-integrations/connectors/destination-bigquery-denormalized/metadata.yaml | ✅ |
Connector version semver check | ✅ |
QA checks | ✅ |
Build connector tar | ✅ |
Build destination-bigquery-denormalized docker image for platform linux/x86_64 | ✅ |
./gradlew :airbyte-integrations:connectors:destination-bigquery-denormalized:integrationTest | ✅ |
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=destination-bigquery-denormalized test
* general cleanup - move stuff around, add more comments * guarantee `getAirbyteProtocolType` won't handle array values for `type` * rename OneOf to Union * simplify union ordering logic * update testChooseUnion * fix docs typos * Automated Commit - Format and Process Resources Changes * address comments * Automated Commit - Format and Process Resources Changes --------- Co-authored-by: cynthiaxyin <cynthiaxyin@users.noreply.github.com>
closes #28054
Recommended reading order: