Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mysql test int types #2908

Merged
merged 2 commits into from
Sep 28, 2021
Merged

mysql test int types #2908

merged 2 commits into from
Sep 28, 2021

Conversation

cgardens
Copy link
Contributor

@cgardens cgardens commented Apr 15, 2021

What

  • trying to debug a user issue where int2 is being treated as a boolean in MySQL. haven't been able to recreate yet. Hoping that he can share the type he has set in MySQL so that I can add it to the test. (slack)

┆Issue is synchronized with this Asana task by Unito

@cgardens
Copy link
Contributor Author

@ChristopheDuong @davinchia reminder to review this please.

@marcosmarxm
Copy link
Member

Just a few ideas that pop out of my head:

  • which MySQL version is used;
  • if source data is stored with some special notion (int2 zerofill, int2 unsigned, etc)

I've run some tests myself and always got the result in postgres as float (double precision);
Another test: Mysql stores boolean as tinyint(1) and in this case Airbyte could transfer correctly as boolean into Postgres.

Copy link
Contributor

@davinchia davinchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a good start!

@davinchia
Copy link
Contributor

@cgardens merge this in?

@CLAassistant
Copy link

CLAassistant commented Sep 27, 2021

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants