Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standard Tests: gradle command for running tests #2936

Merged
merged 1 commit into from
Apr 19, 2021

Conversation

keu
Copy link
Contributor

@keu keu commented Apr 18, 2021

closes #2183

What

Describe what the change is solving
It helps to add screenshots if it affects the frontend.

How

Describe the solution

Pre-merge Checklist

  • Run integration tests
  • Publish Docker images

Recommended reading order

  1. test.java
  2. component.ts
  3. the rest

@keu keu added the zazmic label Apr 18, 2021
@keu keu linked an issue Apr 18, 2021 that may be closed by this pull request
@keu keu requested review from sherifnada, vitaliizazmic and yevhenii-ldv and removed request for cgardens and davinchia April 18, 2021 18:08
Base automatically changed from keu/standard_python-tests/test-suites to keu/standard-python-tests April 19, 2021 14:56
@keu keu force-pushed the keu/standard-python-tests-gradle-cmd branch from 3b11269 to 992e97d Compare April 19, 2021 16:52
Copy link
Contributor

@sherifnada sherifnada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but can we separate the docs changes into the documentation PR so we can roll this out in an "atomic" way?

@@ -26,18 +26,44 @@ See all the test cases and their description in [Standard Source Tests](standard

### Setting up standard tests for your connector
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we separate the doc changes with the full documentation PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@keu keu force-pushed the keu/standard-python-tests-gradle-cmd branch from 2243c25 to eae41d8 Compare April 19, 2021 18:06
@keu keu merged commit b704016 into keu/standard-python-tests Apr 19, 2021
@keu keu deleted the keu/standard-python-tests-gradle-cmd branch April 19, 2021 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Standard tests: Create/update gradle plugins
3 participants