Standard Tests: store/display contexts on test failures #2184 #2951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keu
requested review from
sherifnada and
yevhenii-ldv
and removed request for
jrhizor and
ChristopheDuong
sherifnada
approved these changes
Apr 19, 2021
| logging.info("Running docker, folders: %s", volumes) | ||
| logging.info("Docker run: \n%s\ninput: %s\noutput: %s", cmd, self.input_folder, self.output_folder) | ||
|
|
||
| with open(str(self.output_folder / "raw"), "wb+") as f: |
There was a problem hiding this comment.
How can we prevent this from filling up disk space over time? maybe output should live in /tmp by default?
There was a problem hiding this comment.
output and input folders are in /tmp by default, we take base folder from
tmp_path fixture (builtin pytest fixture)
"""Return a temporary directory path object which is unique to each test
function invocation, created as a sub directory of the base temporary
directory.
"""There was a problem hiding this comment.
so the output looks like this
INFO root:connector_runner.py:108 Docker run:
read --config tap_config.json --catalog catalog.json
input: /tmp/pytest-of-root/pytest-141/test_two_sequential_reads_inpu0/run_1/input
output: /tmp/pytest-of-root/pytest-141/test_two_sequential_reads_inpu0/run_1/output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2184
What
Describe what the change is solving
It helps to add screenshots if it affects the frontend.
How
Describe the solution
Pre-merge Checklist
Recommended reading order
test.javacomponent.ts