Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #72] LinkedIn Ads documentation #30386

Merged
merged 10 commits into from
Sep 14, 2023

Conversation

maxi297
Copy link
Contributor

@maxi297 maxi297 commented Sep 13, 2023

What

Addresses https://github.com/airbytehq/snowflake-native-apps/issues/72

How

Taking the process extracted from https://github.com/airbytehq/snowflake-native-apps/issues/71 and creating a new document describing the process.

This document should not be shown in the sidebar as it is not defined in https://github.com/airbytehq/airbyte/blob/master/docusaurus/sidebars.js. This should make it hidden but still accessible through https://docs.airbyte.com/snowflake-native-apps/linkedin-ads

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Sep 13, 2023
@maxi297 maxi297 requested review from clnoll and brianjlai September 13, 2023 19:29
@brianjlai
Copy link
Contributor

@maxi297 a few notes on changes I pushed to the branch

  • I modified public -> your_schema. Though public is common, I think using your_schema is more accurate because a customer can define their own schemas. And also we did reference schema a few times so better for consistency
  • Added the additional step we need which is to grant CREATE to the app so that it can create the tables if they don’t already exist
  • Renamed the app AIRBYTE_LINKEDIN_ADS and got rid of a few places where we also mentioned test which we should avoid
  • I broke apart some of the bigger blocks of granting permissions into individual bullet points so that we could annotate it more. The comments can make it hard to tell whats it’s doing
  • Removed the under the hood information about calling the stored procedure. I don’t think thats necessary for users to know or understand

Otherwise the rest looks great. Nice work and approved!

docs/snowflake-native-apps/linkedin-ads.md Outdated Show resolved Hide resolved
docs/snowflake-native-apps/linkedin-ads.md Outdated Show resolved Hide resolved
docs/snowflake-native-apps/linkedin-ads.md Outdated Show resolved Hide resolved
docs/snowflake-native-apps/linkedin-ads.md Outdated Show resolved Hide resolved
docs/snowflake-native-apps/linkedin-ads.md Outdated Show resolved Hide resolved
docs/snowflake-native-apps/linkedin-ads.md Outdated Show resolved Hide resolved
docs/snowflake-native-apps/linkedin-ads.md Outdated Show resolved Hide resolved
docs/snowflake-native-apps/linkedin-ads.md Outdated Show resolved Hide resolved
docs/snowflake-native-apps/linkedin-ads.md Outdated Show resolved Hide resolved
docs/snowflake-native-apps/linkedin-ads.md Outdated Show resolved Hide resolved
maxi297 and others added 2 commits September 14, 2023 16:56
Co-authored-by: katmarkham <40400595+katmarkham@users.noreply.github.com>
Copy link
Contributor

@katmarkham katmarkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This layout is much easier to digest! Thanks @maxi297

@maxi297 maxi297 merged commit 886dc43 into master Sep 14, 2023
15 checks passed
@maxi297 maxi297 deleted the snowflake-native-app/linkedin-ads-documentation branch September 14, 2023 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants