-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #72] LinkedIn Ads documentation #30386
Merged
maxi297
merged 10 commits into
master
from
snowflake-native-app/linkedin-ads-documentation
Sep 14, 2023
Merged
[ISSUE #72] LinkedIn Ads documentation #30386
maxi297
merged 10 commits into
master
from
snowflake-native-app/linkedin-ads-documentation
Sep 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octavia-squidington-iii
added
the
area/documentation
Improvements or additions to documentation
label
Sep 13, 2023
maxi297
commented
Sep 13, 2023
@maxi297 a few notes on changes I pushed to the branch
Otherwise the rest looks great. Nice work and approved! |
brianjlai
approved these changes
Sep 14, 2023
maxi297
commented
Sep 14, 2023
katmarkham
reviewed
Sep 14, 2023
katmarkham
reviewed
Sep 14, 2023
Co-authored-by: katmarkham <40400595+katmarkham@users.noreply.github.com>
katmarkham
approved these changes
Sep 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This layout is much easier to digest! Thanks @maxi297
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Addresses https://github.com/airbytehq/snowflake-native-apps/issues/72
How
Taking the process extracted from https://github.com/airbytehq/snowflake-native-apps/issues/71 and creating a new document describing the process.
This document should not be shown in the sidebar as it is not defined in https://github.com/airbytehq/airbyte/blob/master/docusaurus/sidebars.js. This should make it hidden but still accessible through https://docs.airbyte.com/snowflake-native-apps/linkedin-ads