Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source-file/faker: make them use our base image + delete dockerfile #30468

Conversation

alafanechere
Copy link
Contributor

@alafanechere alafanechere commented Sep 15, 2023

What

Relates to #30236
Build source-file and source-faker with our base image

How

  • Set the baseImage metadata
  • Delete their Dockerfiles

User impact

These connectors will be published once all the stacked PR belows are folded and merged in master.

@github-actions
Copy link
Contributor

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@airbytehq airbytehq deleted a comment from github-actions bot Sep 15, 2023
@airbytehq airbytehq deleted a comment from github-actions bot Sep 15, 2023
@airbytehq airbytehq deleted a comment from github-actions bot Sep 15, 2023
@airbytehq airbytehq deleted a comment from github-actions bot Sep 15, 2023
@airbytehq airbytehq deleted a comment from github-actions bot Sep 15, 2023
@github-actions
Copy link
Contributor

source-file test report (commit c8dbe4db79) - ❌

⏲️ Total pipeline duration: 20mn13s

Step Result
Connector package install
Code format checks
Validate airbyte-integrations/connectors/source-file/metadata.yaml
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-file test

@alafanechere alafanechere force-pushed the augustin/09-15-make_QA_checks_tolerate_connector_without_dockerfile branch from fbb9c61 to 001d411 Compare September 15, 2023 14:01
@alafanechere alafanechere force-pushed the augustin/09-15-source-file/faker_make_them_use_our_base_image_delete_dockerfile branch from c8dbe4d to 2859334 Compare September 15, 2023 14:01
@alafanechere alafanechere force-pushed the augustin/09-15-make_QA_checks_tolerate_connector_without_dockerfile branch from 001d411 to 43049f0 Compare September 15, 2023 14:12
@alafanechere alafanechere force-pushed the augustin/09-15-source-file/faker_make_them_use_our_base_image_delete_dockerfile branch from 2859334 to acc3c29 Compare September 15, 2023 14:12
@airbytehq airbytehq deleted a comment from github-actions bot Sep 15, 2023
@airbytehq airbytehq deleted a comment from github-actions bot Sep 15, 2023
@airbytehq airbytehq deleted a comment from github-actions bot Sep 15, 2023
@alafanechere alafanechere force-pushed the augustin/09-15-make_QA_checks_tolerate_connector_without_dockerfile branch from 43049f0 to 2690638 Compare September 15, 2023 15:08
@alafanechere alafanechere force-pushed the augustin/09-15-source-file/faker_make_them_use_our_base_image_delete_dockerfile branch from acc3c29 to e3aebbc Compare September 15, 2023 15:09
@github-actions
Copy link
Contributor

source-file-secure test report (commit e3aebbcdf9) - ❌

⏲️ Total pipeline duration: 01mn39s

Step Result
Build source-file-secure docker image for platform linux/x86_64
Unit tests
Code format checks
Validate airbyte-integrations/connectors/source-file-secure/metadata.yaml
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-file-secure test

@github-actions
Copy link
Contributor

source-file test report (commit e3aebbcdf9) - ❌

⏲️ Total pipeline duration: 02mn35s

Step Result
Build source-file docker image for platform linux/x86_64
Unit tests
Integration tests
Acceptance tests
Code format checks
Validate airbyte-integrations/connectors/source-file/metadata.yaml
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-file test

@alafanechere alafanechere force-pushed the augustin/09-15-make_QA_checks_tolerate_connector_without_dockerfile branch from 2690638 to 5938a15 Compare September 17, 2023 15:16
@alafanechere alafanechere force-pushed the augustin/09-15-source-file/faker_make_them_use_our_base_image_delete_dockerfile branch from e3aebbc to 41c4907 Compare September 17, 2023 15:16
@github-actions
Copy link
Contributor

source-file-secure test report (commit 41c4907fd3) - ❌

⏲️ Total pipeline duration: 01mn03s

Step Result
Build source-file-secure docker image for platform linux/x86_64
Unit tests
Code format checks
Validate airbyte-integrations/connectors/source-file-secure/metadata.yaml
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-file-secure test

@github-actions
Copy link
Contributor

source-faker test report (commit 41c4907fd3) - ✅

⏲️ Total pipeline duration: 01mn53s

Step Result
Build source-faker docker image for platform linux/x86_64
Unit tests
Acceptance tests
Code format checks
Validate airbyte-integrations/connectors/source-faker/metadata.yaml
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-faker test

@github-actions
Copy link
Contributor

source-file test report (commit 41c4907fd3) - ❌

⏲️ Total pipeline duration: 02mn00s

Step Result
Build source-file docker image for platform linux/x86_64
Unit tests
Integration tests
Acceptance tests
Code format checks
Validate airbyte-integrations/connectors/source-file/metadata.yaml
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-file test

@alafanechere alafanechere force-pushed the augustin/09-15-make_QA_checks_tolerate_connector_without_dockerfile branch from 5938a15 to b83cb4d Compare September 18, 2023 10:40
@alafanechere alafanechere force-pushed the augustin/09-15-source-file/faker_make_them_use_our_base_image_delete_dockerfile branch from 41c4907 to b406c99 Compare September 18, 2023 10:40
@github-actions
Copy link
Contributor

source-file-secure test report (commit b406c99444) - ❌

⏲️ Total pipeline duration: 53.48s

Step Result
Build source-file-secure docker image for platform linux/x86_64
Unit tests
Code format checks
Validate airbyte-integrations/connectors/source-file-secure/metadata.yaml
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-file-secure test

@github-actions
Copy link
Contributor

source-faker test report (commit b406c99444) - ✅

⏲️ Total pipeline duration: 01mn46s

Step Result
Build source-faker docker image for platform linux/x86_64
Unit tests
Acceptance tests
Code format checks
Validate airbyte-integrations/connectors/source-faker/metadata.yaml
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-faker test

@github-actions
Copy link
Contributor

source-file test report (commit b406c99444) - ❌

⏲️ Total pipeline duration: 01mn51s

Step Result
Build source-file docker image for platform linux/x86_64
Unit tests
Integration tests
Acceptance tests
Code format checks
Validate airbyte-integrations/connectors/source-file/metadata.yaml
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-file test

@alafanechere alafanechere force-pushed the augustin/09-15-make_QA_checks_tolerate_connector_without_dockerfile branch from b83cb4d to 9029852 Compare September 18, 2023 10:45
@alafanechere alafanechere force-pushed the augustin/09-15-source-file/faker_make_them_use_our_base_image_delete_dockerfile branch from b406c99 to 6d77106 Compare September 18, 2023 10:45
@github-actions
Copy link
Contributor

source-file-secure test report (commit 6d77106d62) - ❌

⏲️ Total pipeline duration: 41.86s

Step Result
Build source-file-secure docker image for platform linux/x86_64
Unit tests
Code format checks
Validate airbyte-integrations/connectors/source-file-secure/metadata.yaml
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-file-secure test

@github-actions
Copy link
Contributor

source-faker test report (commit 6d77106d62) - ✅

⏲️ Total pipeline duration: 56.51s

Step Result
Build source-faker docker image for platform linux/x86_64
Unit tests
Acceptance tests
Code format checks
Validate airbyte-integrations/connectors/source-faker/metadata.yaml
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-faker test

@github-actions
Copy link
Contributor

source-file test report (commit 6d77106d62) - ❌

⏲️ Total pipeline duration: 01mn11s

Step Result
Build source-file docker image for platform linux/x86_64
Unit tests
Integration tests
Acceptance tests
Code format checks
Validate airbyte-integrations/connectors/source-file/metadata.yaml
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-file test

@alafanechere alafanechere force-pushed the augustin/09-15-make_QA_checks_tolerate_connector_without_dockerfile branch from 9029852 to e6bcea4 Compare September 18, 2023 14:16
@alafanechere alafanechere force-pushed the augustin/09-15-source-file/faker_make_them_use_our_base_image_delete_dockerfile branch from 6d77106 to a43d54b Compare September 18, 2023 14:17
@github-actions
Copy link
Contributor

source-file-secure test report (commit a43d54b1e9) - ❌

⏲️ Total pipeline duration: 53.72s

Step Result
Build source-file-secure docker image for platform linux/x86_64
Unit tests
Code format checks
Validate airbyte-integrations/connectors/source-file-secure/metadata.yaml
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-file-secure test

@github-actions
Copy link
Contributor

source-faker test report (commit a43d54b1e9) - ✅

⏲️ Total pipeline duration: 01mn38s

Step Result
Build source-faker docker image for platform linux/x86_64
Unit tests
Acceptance tests
Code format checks
Validate airbyte-integrations/connectors/source-faker/metadata.yaml
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-faker test

@github-actions
Copy link
Contributor

source-file test report (commit a43d54b1e9) - ❌

⏲️ Total pipeline duration: 01mn40s

Step Result
Build source-file docker image for platform linux/x86_64
Unit tests
Integration tests
Acceptance tests
Code format checks
Validate airbyte-integrations/connectors/source-file/metadata.yaml
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-file test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants