[airbyte-ci] fix test regression following secret mounting strategy change #30477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
alafanechere
force-pushed
the
augustin/09-15-_airbyte-ci_fix_test_regression_following_secret_mounting_strategy_change
branch
from
670960b
to
e4d5ef4
Compare
bnchrch
approved these changes
Sep 15, 2023
alafanechere
deleted the
augustin/09-15-_airbyte-ci_fix_test_regression_following_secret_mounting_strategy_change
branch
Merge Activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
A test is not passing as it always assumes the secrets are scrubbed by Dagger.
It's not the case since previous version: we now locally mount secrets as files, not secret.
The scrubbing does not run locally, the test won't pass if it's context is not set to CI.
How
Set the context to CI on this specific test.