🎉 New Source: Zendesk Chat #3088
Conversation
yevhenii-ldv
requested review from
keu,
vitaliizazmic,
vovavovavovavova and
Zirochkaa
and removed request for
sherifnada and
cgardens
|
/test connector=source-zendesk-chat
|
…/new-connector-zendesk-chat � Conflicts: � docs/integrations/connector-health.md
Already formatted |
| from base_python import HttpStream | ||
|
|
||
|
|
||
| class ZendeskChatStream(HttpStream, ABC): |
There was a problem hiding this comment.
this doesn't seem to have any abstract methods, why is it extending ABC?
There was a problem hiding this comment.
Fixed it in PR for Support Incremental #3157
| @@ -0,0 +1,16 @@ | |||
| FROM airbyte/integration-base-python:0.1.4 | |||
There was a problem hiding this comment.
update to latest
| FROM airbyte/integration-base-python:0.1.4 | |
| FROM airbyte/integration-base-python:0.1.6 |
There was a problem hiding this comment.
Updated it in PR for Support Incremental #3157
| stream_data = self.get_stream_data(response_data) | ||
|
|
||
| # Getting rid of duplicates | ||
| if self.pagination_support and response.url.find("since_id") > -1: |
There was a problem hiding this comment.
huh, very interesting problem here. I see why we're doing this. FWIW we can always emit duplicates because Airbyte is at-least-once-delivery. But this is OK 👍🏼
There was a problem hiding this comment.
I removed it in the PR for Incremental, because in the case of the state, it could behave incorrectly, and hide the records
| data_field = "chats" | ||
|
|
||
|
|
||
| class Shortcuts(ZendeskChatStream): |
There was a problem hiding this comment.
lol. Very concise code. Love it.
…/new-connector-zendesk-chat
…ector-zendesk-chat
* Zendesk Chat: Implement Incremental sync * Roll back the stream Chats to the previous endpoint * update integration-base-python to v0.1.6 * update limit to 100 * add acceptence tests * update test and setup configs * remove unknown file * update naming of classes Co-authored-by: ykurochkin <y.kurochkin@zazmic.com> Co-authored-by: Eugene Kulak <kulak.eugene@gmail.com>
|
/test connector=source-zendesk-chat
|
|
/publish connector=connectors/source-zendesk-chat
|
What
Creating new source Zendesk Chat based on Base Python (FULL REFRESH)
closes #3039
How
Describe the solution
Pre-merge Checklist
Recommended reading order
test.javacomponent.ts