Connector Ops: Fix third party support in get_all_connectors_in_repo #31324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
octavia-squidington-iii
added
the
area/documentation
bnchrch
force-pushed
the
bnchrch/fix-third-party-support
branch
from
a851502
to
ad8b683
Compare
|
/approve-and-merge reason="PR was from a previously approved PR" |
|
This looks fine! |
octavia-approvington
approved these changes
Oct 13, 2023
ariesgun
pushed a commit
to ariesgun/airbyte
that referenced
this pull request
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopening of #31166 as I accidentally approved and merged the wrong PR
Problem
Third party pathing breaks
get_all_connectors_in_repoand theConnectorclassrelated to a comment from #30456
Solution
Connectorto take a relative path as its init argument