-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
airbyte-ci: Fix CheckBaseImageIsUsed failing on non certified connectors #31653
airbyte-ci: Fix CheckBaseImageIsUsed failing on non certified connectors #31653
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
d539d55
to
0d548f9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM expect for some unexpected change in pokeapi
@@ -23,3 +23,4 @@ data: | |||
tags: | |||
- language:lowcode | |||
metadataSpecVersion: "1.0" | |||
# TODO: revert |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leftover?
source-pokeapi test report (commit
|
Step | Result |
---|---|
Build source-pokeapi docker image for platform(s) linux/x86_64 | ✅ |
Acceptance tests | ❌ |
Code format checks | ✅ |
Validate metadata for source-pokeapi | ✅ |
Connector version semver check | ✅ |
QA checks | ✅ |
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-pokeapi test
0d548f9
to
ea706f0
Compare
What
Our new check CheckBaseImageIsUsed should be skipped on non certified connectors.
It was not.