-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
airbyte-ci: disable test reports PR comments #31871
airbyte-ci: disable test reports PR comments #31871
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment around deadcode
But this is at a spot where im fine to pre-approve!
@@ -25,6 +25,8 @@ | |||
class ConnectorReport(Report): | |||
"""A dataclass to build connector test reports to share pipelines executions results with the user.""" | |||
|
|||
ENABLE_PR_COMMENTS: bool = False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Im a bit apprehensive of leaving unused code in the code base.
Code is cattle not a pet (ref)
I would argue that we remove it, unless theres a reason to keep it around that I may be missing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When we will consider running the CI on community PRs I think having these comments back can be a good way to expose high-level results to the community contributors. HTML reports are currently private to not overly expose logs.
8547b87
to
775117a
Compare
This reverts commit dee797b.
What
Closes #29300
We don't want PR comments anymore on connector CI test run.
How
The global Connector CI status details will link to the GHA workflow.
The per connector status details will link to the GHA workflow while they're running and to the HTML report when they're done.
Why a 'feature flag' instead of deleting the commenting logic
When we will consider running the CI on community PRs I think having these comments back can be a good way to expose high-level results to the community contributors. HTML reports are currently private to not overly expose logs.