Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

airbyte-ci: custom tag on build #32819

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

alafanechere
Copy link
Contributor

@alafanechere alafanechere commented Nov 27, 2023

What

Closes #31921
We want to allow airbyte-ci users to set a custom tag on locally built connector images

How

  • add a --tag option to connector build, defaults to dev
  • Refactor downstream steps to propagate the option value

Copy link

vercel bot commented Nov 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Nov 29, 2023 1:25pm

Copy link
Contributor Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@alafanechere alafanechere force-pushed the augustin/11-27-airbyte-ci_custom_tag_on_build branch 2 times, most recently from c7aa140 to 52f21e3 Compare November 27, 2023 14:22
@alafanechere alafanechere marked this pull request as ready for review November 27, 2023 14:24
@alafanechere alafanechere requested review from a team and flash1293 November 27, 2023 14:24
Copy link
Contributor

@bnchrch bnchrch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big fan.

Added via Giphy

@alafanechere alafanechere force-pushed the augustin/11-24-airbyte-ci_multi_arch_build branch 2 times, most recently from b9866b0 to 619d58a Compare November 28, 2023 08:17
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't read through all the code, but the interface makes sense to me, thanks!

@alafanechere alafanechere force-pushed the augustin/11-27-airbyte-ci_custom_tag_on_build branch from 52f21e3 to 7f3bc93 Compare November 28, 2023 10:46
@alafanechere alafanechere force-pushed the augustin/11-24-airbyte-ci_multi_arch_build branch 2 times, most recently from 7054179 to f64a96a Compare November 29, 2023 10:24
@alafanechere alafanechere force-pushed the augustin/11-27-airbyte-ci_custom_tag_on_build branch from 7f3bc93 to 3c3d296 Compare November 29, 2023 10:28
@alafanechere alafanechere force-pushed the augustin/11-24-airbyte-ci_multi_arch_build branch from f64a96a to 7c8a6af Compare November 29, 2023 10:36
@alafanechere alafanechere force-pushed the augustin/11-27-airbyte-ci_custom_tag_on_build branch from 3c3d296 to fa52570 Compare November 29, 2023 10:40
Base automatically changed from augustin/11-24-airbyte-ci_multi_arch_build to master November 29, 2023 13:23
@alafanechere alafanechere force-pushed the augustin/11-27-airbyte-ci_custom_tag_on_build branch from fa52570 to bf250a2 Compare November 29, 2023 13:25
@alafanechere alafanechere enabled auto-merge (squash) November 29, 2023 13:26
@alafanechere alafanechere merged commit fb4cf98 into master Nov 29, 2023
21 checks passed
@alafanechere alafanechere deleted the augustin/11-27-airbyte-ci_custom_tag_on_build branch November 29, 2023 13:35
bnchrch added a commit that referenced this pull request Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

airbyte-ci: expose a --tag option on build
3 participants