Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

airbyte-ci: fix BuildConnectorImages constructor #32928

Conversation

alafanechere
Copy link
Contributor

@alafanechere alafanechere commented Nov 29, 2023

What

#32816 changed the signature of BuildConnectorImages's constructors but some calls were not updated.

Copy link

vercel bot commented Nov 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Nov 29, 2023 2:14pm

Copy link
Contributor Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@alafanechere alafanechere marked this pull request as ready for review November 29, 2023 14:06
@alafanechere alafanechere requested a review from a team November 29, 2023 14:06
@alafanechere alafanechere force-pushed the augustin/11-29-airbyte-ci_fix_BuildConnectorImages_constructor branch from de4c666 to 51b16c9 Compare November 29, 2023 14:13
@alafanechere
Copy link
Contributor Author

/approve-and-merge reason="patching a regression blocking the CI"

@octavia-approvington
Copy link
Contributor

You did it!
finish line

@octavia-approvington octavia-approvington merged commit 9f3cc89 into master Nov 29, 2023
22 checks passed
@octavia-approvington octavia-approvington deleted the augustin/11-29-airbyte-ci_fix_BuildConnectorImages_constructor branch November 29, 2023 14:25
bnchrch added a commit that referenced this pull request Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants