airbyte-ci: format improvements

[postamar]

This PR removes the dependency on gradle for airbyte-ci's format command. This PR also improves the performance of the python formatting.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
airbyte-docs	⬜️ Ignored (Inspect)	Visit Preview		Dec 1, 2023 4:43pm

[postamar]

This was not called anywhere.

[postamar]

This should speed up the python formatting by caching the poetry install which depends on a poetry.lock file which changes very little over time.

[erohmensing]

Only major concern is around the mounting

[alafanechere]

Requesting change as I think:

return await format_container.directory("/airbyte/repo").export(".")

is a typo, it should export /src. I'll try to push a fix

[alafanechere]

This is great!
Using maven instead of gradle allows us to not suffer from the overhead of starting and configuring gradle + messing up with its cache.

I pushed the small fix in term of consistency of repo mount path.

I checked the check all performances after modifying a python and a java file:
Runs in 30 seconds 👍.

(The first time you run airbyte-ci format check all is definitely longer as we're pulling images from remote registries and install deps: I confirm all this is cached in subsequent runs.)

[postamar]

Alright, this should be good to go.

[postamar]

Notice that the autoformat is failing, but that's expected, as I removed the spotless plugin from the build.gradle and the autoformat is running with the published binary which doesn't yet have the changes in this PR.

[erohmensing]

Looks great!

[postamar]

Thanks for the reviews! I'll merge shortly.

[postamar]

I've reverted 22e1bbd and will put it in a separate follow-up PR to not force-merge this one.