Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎉 source: clickhouse setup docs #3375

Merged
merged 3 commits into from
May 13, 2021
Merged

🎉 source: clickhouse setup docs #3375

merged 3 commits into from
May 13, 2021

Conversation

subodh1810
Copy link
Contributor

@subodh1810 subodh1810 commented May 12, 2021 •
edited
Loading

What

Issue : #3317

Tested it in local
Screenshot 2021-05-12 at 4 45 57 PM

How

Describe the solution

Pre-merge Checklist

  • Run integration tests
  • Publish Docker images

Recommended reading order

  1. test.java
  2. component.ts
  3. the rest

@subodh1810 subodh1810 requested a review from davinchia May 12, 2021 10:48
@subodh1810 subodh1810 self-assigned this May 12, 2021
@subodh1810
Copy link
Contributor Author

subodh1810 commented May 12, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-clickhouse

🕑 connectors/source-clickhouse https://github.com/airbytehq/airbyte/actions/runs/835175831
✅ connectors/source-clickhouse https://github.com/airbytehq/airbyte/actions/runs/835175831

ChristopheDuong
ChristopheDuong reviewed May 12, 2021
View reviewed changes
...c/main/resources/config/STANDARD_SOURCE_DEFINITION/bad83517-5e54-4a3d-9b53-63e85fbd4d7c.json Outdated
{
"sourceDefinitionId": "bad83517-5e54-4a3d-9b53-63e85fbd4d7c",
"name": "ClickHouse",
"dockerRepository": "airbyte/source-clickhouse./gradlew generateSeed./gradlew generateSeed",
Copy link
Contributor

@ChristopheDuong ChristopheDuong May 12, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is bad, typo?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah! stupid me!

davinchia
davinchia reviewed May 13, 2021
View reviewed changes
docs/integrations/sources/clickhouse.md Outdated

### Requirements

1. ClickHouse Server `21.3.10.1`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spoke about this: Let's make this version or later.

davinchia
davinchia approved these changes May 13, 2021
View reviewed changes
Copy link
Contributor

@davinchia davinchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIce! Merge after the version is updated.

sherifnada
sherifnada approved these changes May 13, 2021
View reviewed changes
Copy link
Contributor

@sherifnada sherifnada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏼

@subodh1810 subodh1810 merged commit 69125cf into master May 13, 2021
@subodh1810 subodh1810 deleted the clickhouse-source-docs branch May 13, 2021 08:05
@subodh1810 subodh1810 mentioned this pull request May 13, 2021
Closed
@subodh1810 subodh1810 changed the title source: clickhouse setup docs 🎉 source: clickhouse setup docs May 13, 2021
@davinchia davinchia mentioned this pull request May 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sherifnada sherifnada sherifnada approved these changes

@davinchia davinchia davinchia approved these changes

@cgardens cgardens Awaiting requested review from cgardens

@masonwheeler masonwheeler Awaiting requested review from masonwheeler

@ChristopheDuong ChristopheDuong Awaiting requested review from ChristopheDuong

Assignees

@subodh1810 subodh1810

Labels
connectors/source/clickhouse connectors/sources-database
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@subodh1810 @sherifnada @ChristopheDuong @davinchia @igrankova