-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
airbyte-ci: re-introduce mypy #33964
Merged
octavia-approvington
merged 4 commits into
master
from
augustin/01-05-airbyte-ci_re-introduce_mypy
Jan 5, 2024
Merged
airbyte-ci: re-introduce mypy #33964
octavia-approvington
merged 4 commits into
master
from
augustin/01-05-airbyte-ci_re-introduce_mypy
Jan 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
octavia-squidington-iii
added
area/connectors
Connector related issues
connectors/source/faker
labels
Jan 5, 2024
alafanechere
force-pushed
the
augustin/01-05-airbyte-ci_re-introduce_mypy
branch
from
January 5, 2024 09:58
b3e3c7a
to
de1c1cc
Compare
alafanechere
force-pushed
the
augustin/01-05-airbyte-ci_re-introduce_mypy
branch
from
January 5, 2024 10:12
de1c1cc
to
4de9510
Compare
alafanechere
force-pushed
the
augustin/01-05-airbyte-ci_re-introduce_mypy
branch
from
January 5, 2024 10:13
4de9510
to
fe5650c
Compare
/approve-and-merge reason="fixing airbyte-ci regression" |
octavia-approvington
approved these changes
Jan 5, 2024
octavia-approvington
deleted the
augustin/01-05-airbyte-ci_re-introduce_mypy
branch
January 5, 2024 10:42
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 26, 2024
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Re-introduce changes from #33785 which got reverted due to a regression on test and publish pipeline:
How
assert report is not None
was set too early in the code path